Avoid expensive and pointless stuff in VerticalRemapper constructor #2642
Conversation
…uctor We don't need to create a hard copy of the src grid, nor do we need to find the unique gids. All we need is a (shallow) clone, with a different number of levs
bartgol
added
BFB
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
…structor The clone method already sets the geo data
|
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has pushed a change to the PR before testing completed. NEW EVENT 'committed', ID C_kwDOCEfuetoAKGQ0YzM5OWM2NWMxZThmNTVhNzRlZWE0ZTc5NmU3NjkyYTlkNjZkNGY... The Jenkins Jobs will be shutdown; Testing of this PR must occur again. |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4700 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5176 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
When creating a tgt/src FieldIdentifier from a src/tgt one, we do not need to check the name of the grid in the src/tgt one. In fact, grids can be aliased, without changing any internal detail, or with changes that are irrelevant.
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4701 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5177 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4702 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5178 (click to expand) |
Rather than checking the grid name, all we need is to check that the field layout is valid.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4703 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5179 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4705 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5181 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4708 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5183 (click to expand) |
E3SM-Autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
| @@ -336,7 +336,7 @@ void Nudging::initialize_impl (const RunType /* run_type */) | |||
| auto nudging_weights = create_helper_field("nudging_weights", scalar3d_layout_mid, grid_name, ps); | |||
| std::vector<Field> fields; | |||
| fields.push_back(nudging_weights); | |||
| AtmosphereInput src_weights_input(m_weights_file, grid_ext, fields); | |||
| AtmosphereInput src_weights_input(m_weights_file, m_grid, fields); | |||
There was a problem hiding this comment.
@elynnwu The test was failing without this change. The way we now check compatibility of fields in FieldManager::add_field showed that the layout was wrong (not the right number of levels, compared to the FM grid). I think this was indeed a bug. You should double check though.
There was a problem hiding this comment.
@xyuan Perhaps I should ping you as well, since git blame shows your name for those lines...
There was a problem hiding this comment.
Yes, I think you are correct Luca.
There was a problem hiding this comment.
This was a bug due to the coarse nudging PR #2613 (I should have changed it from grid_ext to grid_int or m_grid) as I did a few lines prior... Thanks for the fix!
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
From a slack conversation with @ndkeen : We should probably still check to ensure that our I/O setup is not doing pointless/redundant/inefficient work. The scream-autotuning simulation campaign will benefit from even a handful of seconds of init cost saving. |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4709 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5184 (click to expand) |
…yout Not just "CMP", but also "SWBND", "LBND", "SWGPT", ...
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4712 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5187 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
| result = LayoutType::Vector3D; | ||
| } else if (tags[0]==TL && tags[1]==CMP ) { | ||
| } else if (tags[0]==TL && is_vec_tag(tags[1]) ) { | ||
| result = LayoutType::Tensor2D; | ||
| } | ||
| break; | ||
| case 3: | ||
| // The only supported scenario is: | ||
| // 1) <TL, CMP, LEV|ILEV> |
There was a problem hiding this comment.
I guess we could update the comments in this section of code to not say CMP but something including all possible vector tags.
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ AaronDonahue ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
E3SM-Autotester
deleted the
bartgol/eamxx/fix-vertical-remap-constructor
branch
|
Merge on Pull Request# 2642: IS A SUCCESS - Pull Request successfully merged |
E3SM-Autotester
removed
the
AT: AUTOMERGE
We don't need to create a whole new grid as our tgt grid, and we also don't need to find out which gids in the src grid are unique. All we need is a shallow clone of the src grid, resetting the number of vert levs.