Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support external data #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KateSakharova
Copy link
Contributor

  • added samplesheet support for multiple runs

@KateSakharova KateSakharova force-pushed the feature/support-external-data branch from 98394e5 to a26c499 Compare July 1, 2024 11:52
@KateSakharova KateSakharova marked this pull request as ready for review July 1, 2024 11:53
@KateSakharova KateSakharova self-assigned this Jul 1, 2024
@KateSakharova KateSakharova requested a review from Ge94 July 1, 2024 11:53
Copy link
Member

@Ge94 Ge94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I just left a couple clarification comments here and there

}
},
"required": ["sample", "fastq_1"]
"required": ["study_accession","reads_accession", "fastq_1", "library_layout", "library_strategy"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, these are all fields that will be received from prefect?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I see these will be overridden in the miassembler workflow when a samplesheet is used. So, are these still required fields?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is either to submit --study and --run-accession OR to use a samplesheet. The values from the samplesheet have the highest priority.

"library_strategy": {
"type": "string",
"enum": ["metagenomic", "metatranscriptomic", "genomic", "transcriptomic", "other"],
"errorMessage": "library strategy should be only value from list: 'metagenomic', 'metatranscriptomic', 'genomic', 'transcriptomic', 'other'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will the "other" case be handled from prefect? e.g. in the case metadata are wrong and we realise the data are metaG/metaT and so on, is prefect going to default everything to "other" or is a manual input needed from us? In the latter case, what does "other" cover?

"blast_reference_genomes_folder",
"bwamem2_reference_genomes_folder",
"outdir",
"human_phix_blast_index_name",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these two index names be required also in the other case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants