Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Antismash module #44

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Antismash module #44

merged 10 commits into from
Jul 5, 2024

Conversation

chrisAta
Copy link
Member

No description provided.

@chrisAta chrisAta self-assigned this Jun 11, 2024
mberacochea
mberacochea requested changes Jun 27, 2024
View reviewed changes
modules/ebi-metagenomics/antismash/main.nf Outdated Show resolved Hide resolved
modules/ebi-metagenomics/antismash/main.nf Outdated Show resolved Hide resolved
@mberacochea
Copy link
Member

Nice!. I just noticed we are not running nf-tests on Github Actions (this is not a problem with this PR BTW)

mberacochea
mberacochea requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!. I love the trimmed antismash db, the test won't fully use that because the container already has it. We need to re-build that container .. at some point.

modules/ebi-metagenomics/antismash/main.nf Outdated Show resolved Hide resolved
modules/ebi-metagenomics/antismash/meta.yml Outdated Show resolved Hide resolved
modules/ebi-metagenomics/antismash/tests/main.nf.test Show resolved Hide resolved
@chrisAta chrisAta requested a review from mberacochea July 5, 2024 10:05
mberacochea
mberacochea approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks @chrisAta

@chrisAta chrisAta merged commit 84bf1a3 into main Jul 5, 2024
6 checks passed
@chrisAta chrisAta deleted the antismash branch September 2, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberacochea mberacochea mberacochea approved these changes

Assignees

@chrisAta chrisAta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisAta @mberacochea