-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/eggnogmapper #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work with the inputs, thanks!! I am not sure how the annotation input mode works, but I see it only uses the eggonog data dir, and not the eggong db itself. And probably it's either the fasta file, for the first mode, or the annotation file, for the second mode. Left some comments here and there!
…nd other code review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Refactor eggnogmapper to have less hardcoded things. This should allow it to be used to for annotation and mapping depending on the supplied
$args
like here: https://github.com/EBI-Metagenomics/mettannotator/blob/main/modules/local/eggnog.nf