Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch and insert all possible seqCol objects from one assembly read #22

Conversation

waterflow80
Copy link
Collaborator

Now we can fetch and insert all possible seqCol objects from one assembly read.
Note: "all possible" means with all the naming conventions that are provided in the assembly report.

Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one method name suggestion 👍 (Also, don't forget to rebase and make sure tests pass before you merge.)

@PutMapping(value = "/seqcols/{asmAccession}/{namingConvention}")
* Fetch and insert all possible seqCol objects given the assembly accession
* NOTE: All possible means with all naming conventions that exist in the fetched assembly report*/
@PutMapping(value = "/seqcols/{asmAccession}")
public ResponseEntity<?> fetchAndInsertSeqColByAssemblyAccessionAndNamingConvention(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public ResponseEntity<?> fetchAndInsertSeqColByAssemblyAccessionAndNamingConvention(
public ResponseEntity<?> fetchAndInsertSeqColByAssemblyAccession(

@waterflow80 waterflow80 force-pushed the constrcut-multiple-seqcol-from-one-assembly-read branch from cc12985 to dfb4324 Compare August 7, 2023 14:07
@waterflow80 waterflow80 merged commit 35692bd into EBIvariation:main Aug 7, 2023
1 check passed
@waterflow80 waterflow80 deleted the constrcut-multiple-seqcol-from-one-assembly-read branch October 20, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants