EVA-3529 Notify submission update to user through email #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nitin-ebi
commented
Mar 14, 2024
nitin-ebi
commented
apriltuesday
approved these changes
Mar 15, 2024
| @@ -85,9 +95,17 @@ public boolean checkUserHasAccessToSubmission(SubmissionAccount account, String | |||
| Optional<Submission> optSubmission = submissionRepository.findById(submissionId); | |||
| if (optSubmission.isPresent()) { | |||
| SubmissionAccount submissionAccount = optSubmission.get().getSubmissionAccount(); | |||
| return submissionAccount.getId() == account.getId(); | |||
| return submissionAccount.getId().equals(account.getId()); | |||
There was a problem hiding this comment.
I assume this fixes EVA-3536 as well 👍
| .addGap(1) | ||
| .addText("Here is the update for your submission: ") | ||
| .addGap(1) | ||
| .addText("submission id: " + submissionId) |
There was a problem hiding this comment.
Suggested change
| .addText("submission id: " + submissionId) | |
| .addText("Submission ID: " + submissionId) |
| @@ -87,6 +88,7 @@ public ResponseEntity<?> markSubmissionUploaded(@RequestHeader("Authorization") | |||
| } | |||
|
|
|||
| Submission submission = this.submissionService.markSubmissionUploaded(submissionId); | |||
| submissionService.sendMailNotificationForStatusUpdate(submissionAccount, submissionId, SubmissionStatus.UPLOADED, Boolean.TRUE); | |||
There was a problem hiding this comment.
Just curious, is there a reason to use a Boolean object here instead of a primitive?
There was a problem hiding this comment.
Not really and frankly not needed. Have changed to primitive to be consistent
apriltuesday
approved these changes
Mar 18, 2024
tcezard
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.