Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat prms tests #241

Merged
merged 9 commits into from
Oct 4, 2023
Merged

Feat prms tests #241

merged 9 commits into from
Oct 4, 2023

Conversation

jmccreight
Copy link
Member

@jmccreight jmccreight commented Sep 29, 2023

  • Partially addresses Overhaul tests against PRMS output #238

    • Refactor PRMSChannel, PRMSGroundwater, PRMSSolarGeometry
    • Introduce common utils for comparing results both in memory and in file
  • Tests added: tests improved and refactor to fit into CI storage

  • Fix bug with new matplotlib version. (no issue)

  • Fix bug with new xarray version. (no issue)

  • Handle acceptable warnings in pytests

Finished by #244

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #241 (48db5fd) into develop (fb9a0f3) will decrease coverage by 0.48%.
The diff coverage is 57.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #241      +/-   ##
===========================================
- Coverage    79.19%   78.71%   -0.48%     
===========================================
  Files           51       51              
  Lines         6536     6539       +3     
===========================================
- Hits          5176     5147      -29     
- Misses        1360     1392      +32     
Files Coverage Δ
pywatershed/hydrology/prms_runoff.py 82.36% <100.00%> (-0.24%) ⬇️
pywatershed/hydrology/prms_snow.py 89.56% <100.00%> (-1.05%) ⬇️
pywatershed/hydrology/prms_soilzone.py 88.23% <100.00%> (ø)
pywatershed/analysis/process_plot.py 16.93% <0.00%> (ø)
pywatershed/utils/prms5util.py 31.77% <33.33%> (+0.02%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmccreight jmccreight merged commit a6e5646 into EC-USGS:develop Oct 4, 2023
9 checks passed
@jmccreight jmccreight mentioned this pull request Oct 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants