Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cottle version is out of date #1687

Closed
Tkael opened this issue Jan 18, 2020 · 3 comments · Fixed by #1836
Closed

Cottle version is out of date #1687

Tkael opened this issue Jan 18, 2020 · 3 comments · Fixed by #1836
Assignees
Labels
10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user.

Comments

@Tkael
Copy link
Member

Tkael commented Jan 18, 2020

EDDI version in which issue is found

3.5.3

VoiceAttack version in which issue is found (as applicable)

N/A

Steps to reproduce

  1. Visit https://github.com/r3c/cottle and note the release number
  2. Visit the recently revised Cottle documentation page at https://cottle.readthedocs.io/. Note that the documents there (with the exception of the update guide) only describe the latest version and not version 1.4.0.4 (the version EDDI currently uses).

Expected

Cottle documentation available on the internet matches EDDI's implementation

Observed

Differences may develop since EDDI is using Cottle version 1.4.0.4 while the latest stable release is 1.6.0.

Investigation

Cottle version 1.4.0.4 was the last version prior to Cottle rolling to a requirement for .Net version 4.7.2. Updating would require

  1. Retargeting from .Net version 4.7.1 to 4.7.2.
  2. Updating the Cottle package and following the documented versioning update guide.
@Tkael Tkael added the 10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user. label Jan 18, 2020
@Tkael
Copy link
Member Author

Tkael commented Feb 11, 2020

I intend to work on this once #1682 is merged.

@Tkael Tkael self-assigned this Feb 11, 2020
@Tkael Tkael added the on hold label Feb 11, 2020
@Tkael Tkael added active Someone is working on it already. PR submitted A PR has been submitted, but not accepted yet. and removed on hold active Someone is working on it already. labels Jun 19, 2020
This was referenced Jun 20, 2020
@Tkael Tkael removed the PR submitted A PR has been submitted, but not accepted yet. label Jul 3, 2020
@Tkael Tkael reopened this Jul 3, 2020
@richardbuckle
Copy link
Member

We are currently on the latest version of Cottle that allows us to write functions that re-parse string arguments using the live context. If we need to update then we would have to persuade the Cottle maintainers to add explicit support for this. We are their second largest open-source consumer on GitHub so that might be possible.

@Tkael
Copy link
Member Author

Tkael commented Aug 7, 2024

Resolved in 4.1.0-b1.

@Tkael Tkael closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants