Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cottle version #1836

Merged
merged 5 commits into from
Jun 22, 2020
Merged

Update Cottle version #1836

merged 5 commits into from
Jun 22, 2020

Conversation

Tkael
Copy link
Member

@Tkael Tkael commented Jun 21, 2020

Resolves #1687.
Rebased from #1834.

Note: There is 1 failing unit test which may represent a change to how Cottle handles nested functions?
- Test method is unchanged from version 1.6.2 (which passed)
- Test method is a pure test of Cottle functionality - it does not invoke the ScriptResolver class and is unaffected by changes to that class.
Fix missing parenthesis after re-base.
@Tkael Tkael self-assigned this Jun 21, 2020
@Tkael Tkael added the 10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user. label Jun 21, 2020
@Tkael Tkael requested a review from richardbuckle June 21, 2020 07:39
@Tkael Tkael merged commit ccc4753 into develop Jun 22, 2020
@Tkael Tkael deleted the hotfix/1687-cottle branch June 22, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cottle version is out of date
2 participants