Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1781 split eddi project #1796

Closed
wants to merge 7 commits into from
Closed

1781 split eddi project #1796

wants to merge 7 commits into from

Conversation

GioVAX
Copy link
Contributor

@GioVAX GioVAX commented May 30, 2020

This should include the bulk of file modifications.

The next stage will be removing references to namespace EDDI from namespace EddiCore.

Step 1 for issue #1781.

@Tkael Tkael added the 10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user. label May 31, 2020
EDDI/EDDI.cs Outdated Show resolved Hide resolved
@Tkael
Copy link
Member

Tkael commented Jun 4, 2020

Need to add EddiCore.csproj to EDDI.sln?

EDDI/App.xaml.cs Outdated Show resolved Hide resolved
Copy link
Member

@richardbuckle richardbuckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I hope it has given you a good tour of the code base.
This looks good for step 1.
I shall implement my requests myself, to save time.

EDDI/App.xaml.cs Show resolved Hide resolved
EDDI/EDDI.cs Show resolved Hide resolved
EddiCore/EddiCore.csproj Show resolved Hide resolved
EddiCore/EddiCore.csproj Show resolved Hide resolved
EddiCore/EddiCore.csproj Show resolved Hide resolved
EDDI/MainWindow.xaml.cs Show resolved Hide resolved
EDDI/EddiUpgrader.cs Show resolved Hide resolved
EDDI/EDDI.cs Show resolved Hide resolved
EDDI/EDDI.cs Show resolved Hide resolved
EDDI/EDDI.cs Show resolved Hide resolved
@richardbuckle
Copy link
Member

PS @GioVAX you should now have write access to this repo, so no more need to work in your own fork.

@richardbuckle richardbuckle removed the request for review from Hoodathunk June 8, 2020 21:56
@richardbuckle
Copy link
Member

Parking for rebase into main repo so I can add commits.

@richardbuckle
Copy link
Member

Closing for the rebased #1815

@GioVAX GioVAX deleted the 1781-SplitEddiProject branch June 22, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10. work unit (user unaffected) A job that needs to be done but which doesn't affect the user. on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants