Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Italian translation #2085

Closed
wants to merge 6 commits into from
Closed

Updated the Italian translation #2085

wants to merge 6 commits into from

Conversation

GLWine
Copy link
Contributor

@GLWine GLWine commented Oct 30, 2023

Added and corrected missing lines of code for the Italian language.
Change made to Inara.py and EDSM.py files:
Fixed the section of code that integrates the Show API Key text translation call that was not written in such a way as to be actually translated.

Added and corrected about 50 sentences in the list
Corrected the "text"s to integrate the translation of the new additions: line 285 and line 295.
Also added an explanatory comment.
Corrected the "text" to integrate the translation of the new addition: line 355.
Also added an explanatory comment.
Corrected the "text"s to integrate the translation of the new additions: line 285 and line 295.
Also added an explanatory comment.
@Athanasius
Copy link
Contributor

@Rixxan and @C1701D need to get up to speed with the OneSky workflow.

Translators should see #24 .

Merging this PR would just get undone the next time OneSky translations are merged in (special-casing Italian because of this PR would just cause long-term issues, the updated translations really need to be on OneSky unless the active developers decide to stop using that).

Now I check, I see that GLWine has been attempting update on OneSky as well.

So, yes, let's sort out the new developers having access to OneSky. I do have a secondary account with all the admin rights (from when github auth was broken) which we can probably get transferred across. I would highly suggest doing something like making a new gmail/hotmail/whatever account so that it could be transferred more easily if needs be in the future and getting it migrated to that.

@Athanasius
Copy link
Contributor

Here's the latest OneSky download of all the translations in their current state:
EDMarketConnector-Tanslations-OneSky-20231030.zip

@GLWine
Copy link
Contributor Author

GLWine commented Oct 30, 2023

I apologize, but the part about email and GitHub is not entirely clear to me. If you can explain better. For me, I still understand the choice not to integrate the pool, however the part about the two files EDSM.py and Inara.py.

In OneSky I made comments about some blocked translations, which perhaps could be changed.

@Athanasius
Copy link
Contributor

I apologize, but the part about email and GitHub is not entirely clear to me. If you can explain better. For me, I still understand the choice not to integrate the pool, however the part about the two files EDSM.py and Inara.py.

In OneSky I made comments about some blocked translations, which perhaps could be changed.

That was for @Rixxan and @C1701D , you don't need to worry about it.

@GLWine
Copy link
Contributor Author

GLWine commented Oct 30, 2023

I apologize, but the part about email and GitHub is not entirely clear to me. If you can explain better. For me, I still understand the choice not to integrate the pool, however the part about the two files EDSM.py and Inara.py.
In OneSky I made comments about some blocked translations, which perhaps could be changed.

That was for @Rixxan and @C1701D , you don't need to worry about it.

At this point I close the pull, and redo one of just the Inara.py and EDSM.py files. So as to at least correct the missing hook for the translation.

@GLWine GLWine closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants