Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ttk-based theming #2241

Draft
wants to merge 67 commits into
base: develop
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
d0ca7aa
Excluded ttk widgets from theme.theme
ElSaico May 26, 2024
343ee8a
Changed all main window widgets to ttk
ElSaico May 26, 2024
34dab8e
Fixed type signatures caught up by mypy
ElSaico May 26, 2024
fa3ab46
As I was saying, fixed type signatures...
ElSaico May 26, 2024
a017139
meh
ElSaico May 26, 2024
d18a8d4
We don't need to actually change the killswitch
ElSaico May 26, 2024
a40a10e
Added JSON theme
ElSaico May 27, 2024
19994ac
Simplified style, fixed HyperlinkLabel underline font
ElSaico May 27, 2024
9ba7ee5
Set baseline for themes
ElSaico May 27, 2024
a034bb7
Integrated ttk themes in theme.apply()
ElSaico May 27, 2024
7fd086b
oops
ElSaico May 27, 2024
899c773
Leftover import
ElSaico May 27, 2024
47de607
Applying theme palette to Tk widgets more reliably
ElSaico May 27, 2024
7c4ea70
Caught a plugin using theme.register() directly, so reinstated as stub
ElSaico May 27, 2024
881840c
Added Ttk catalog plugin (enabled by flag)
ElSaico May 27, 2024
b971c26
Fixed TTK Catalog positioning
ElSaico May 28, 2024
2b8158d
Ttk catalog: replaced alternative styles with HyperlinkLabel frame
ElSaico Jun 1, 2024
08a031c
Nicer labels
ElSaico Jun 1, 2024
6bb0475
Using clam as the base ttk theme on Windows
ElSaico Jun 2, 2024
4cfe990
Added Tk widgets to Ttk catalog for comparison
ElSaico Jun 2, 2024
ca4a5ef
Theme in pure Tcl
ElSaico Jun 2, 2024
65a33bb
Fixed theme font
ElSaico Jun 2, 2024
960fef9
Ttk catalog: properly labeled Tk widgets
ElSaico Jun 2, 2024
f1ad8d7
Added default theme; final touches in dark?
ElSaico Jun 2, 2024
8f94a02
Merge branch 'develop' into ttk
ElSaico Jun 3, 2024
0955304
flake8
ElSaico Jun 3, 2024
c332892
mypy
ElSaico Jun 3, 2024
18c1c3a
Themes as tcl packages, deprecated most of myNotebook
ElSaico Jun 3, 2024
4f54b49
HyperlinkLabel is a Button. Obviously.
ElSaico Jun 4, 2024
de89528
Fixed underline font
ElSaico Jun 4, 2024
2fd9f7f
A possible solution for HyperlinkLabel on the way?
ElSaico Jun 7, 2024
168bc3e
Dropped most of myNotebook from core plugins (except for EntryMenu)
ElSaico Jun 8, 2024
853accd
HyperlinkLabel seems to work now
ElSaico Jun 8, 2024
a33c07e
Dropped unnecessary tk call
ElSaico Jun 8, 2024
1f0bedd
Dropping justify config in HyperlinkLabel
ElSaico Jun 8, 2024
4ef4880
Slight cleanup on font loading code
ElSaico Jun 9, 2024
87fb27a
Added check to whether Euro Caps actually loads on Windows
ElSaico Jun 9, 2024
254ec5d
Some words of encouragement
ElSaico Jun 9, 2024
94399cd
Better deprecation notices on theme.register() and theme.update()
ElSaico Jun 9, 2024
f13636d
Something to the logs
ElSaico Jun 9, 2024
9829575
Proper theme/myNotebook deprecation warnings
ElSaico Jun 9, 2024
2634e6e
We don't need most of nb now, so...
ElSaico Jun 9, 2024
ebb3a70
Dropped ttk::theme lookup on theme files
ElSaico Jun 9, 2024
0f7b48a
Merge remote-tracking branch 'refs/remotes/edcd/develop' into ttk
ElSaico Jun 9, 2024
9be31f6
Merge branch 'develop' into ttk
Rixxan Jun 10, 2024
3a0e49e
Merge remote-tracking branch 'origin/ttk' into ttk
ElSaico Jun 10, 2024
9156918
Dropped post-merge repetition
ElSaico Jun 11, 2024
e45e8c0
Dropped alternative title bar and update button
ElSaico Jun 11, 2024
e6f8580
Using native dark mode title bar on Windows
ElSaico Jun 11, 2024
199110e
Removed widget switcheroo, all themes use the same menu
ElSaico Jun 13, 2024
2a7db41
Style tweaks
ElSaico Jun 14, 2024
6ceda6a
Merge remote-tracking branch 'refs/remotes/edcd/develop' into ttk
ElSaico Jun 19, 2024
44d1e68
Customizing title bar via PyWinRT
ElSaico Jun 24, 2024
a7361fe
Import shenanigans now that pywinrt works
ElSaico Jun 24, 2024
f680682
We no longer need those drag events
ElSaico Jun 24, 2024
0217c35
Merge branch 'refs/heads/develop' into ttk-rt
ElSaico Jul 22, 2024
810fa2b
Bump WinRT dependency (as it missed a DLL)
ElSaico Jul 22, 2024
ff35b8d
Merge branch 'refs/heads/develop' into ttk
ElSaico Jul 22, 2024
64be73c
Post-merge clarity
ElSaico Jul 22, 2024
50d9e41
Fixed pywin32 call
ElSaico Jul 22, 2024
d3fef97
whoops
ElSaico Jul 22, 2024
ee589e7
Added gap for custom title bar under Transparent
ElSaico Jul 23, 2024
0ad93ad
Using PyWinRT visual layer
ElSaico Aug 20, 2024
bf04ce9
Merge remote-tracking branch 'edcd/develop' into ttk
ElSaico Aug 20, 2024
5f444e7
Post-merge ttk catalog fix
ElSaico Aug 20, 2024
c4fab48
Some simplification and making mypy happier
ElSaico Aug 21, 2024
9f87cd6
Ditched visual layer + setting Windows caption button colors
ElSaico Aug 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We don't need most of nb now, so...
ElSaico committed Jun 9, 2024
commit 2634e6e99f2612fe8a32304be4ee3aa1da7526e0
6 changes: 1 addition & 5 deletions myNotebook.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
"""
Custom `ttk.Notebook` to fix various display issues.

Hacks to fix various display issues with notebooks and their child widgets on Windows.

- Windows: page background should be White, not SystemButtonFace

Entire file may be imported by plugins.
This is mostly no longer necessary, with ttk themes applying consistent behaviour across the board.
"""
from __future__ import annotations