pass Horizons/Odyssey flags in NavRoute #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old workaround appears to be not needed anymore. EDDN accepts NavRoute with Horizons/Odyssey flags now. EDDiscovery, EDO Materials Helper and others also set these flags.
|
Hey @HansAcker! Thanks for submitting. Just wanting to check, this change you're suggesting, is compliant with https://github.com/EDCD/EDDN/blob/master/docs/Developers.md#horizons-and-odyssey-flags? Notably, we're only adding these keys when we're 100% certain and not adding Odyssey: False (Odyssey only exists if True)? |
|
As far as I can tell, it is. A NavRoute event always arrives after the game variant was determined, if I understand it right. I tested a modified build in both Odyssey and Horizons (live, not legacy) and the routes always had the correct flags on them. It's probably of no great consequence to leave them out of route events, either. |
|
As far as I can tell this is correct and seems to be working. Looks good, let's give it a shot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old workaround appears to be not needed anymore. EDDN accepts NavRoute with Horizons/Odyssey flags now.
EDDiscovery, EDO Materials Helper and others also set these flags.
Type of Change
Removed workaround code from when EDDN did not accept these flags in NavRoute events.
How Tested
I built and installed a release, produced NavRoute events and watched them come through the EDDN gateway.
Notes
Mentioned in #1310