New intro page #1930
New intro page #1930
Conversation
- Restore missing alt attributes. - Set alt to "" for decorative images.
|
@ghostwords Thanks for your helpful review and feedback! |
|
OK, we should be almost ready to merge and push the updated locales to translators. @andresbase @bcyphers @lschatzkin Could you take a look and let me know if you find any issues? Note that I tweaked the text a little (adding a couple of links, for instance). |
|
LGTM other than comment on the alt tags. |
|
Regarding alt attributes: I was following advice given by https://webaim.org/techniques/alttext/. If the image doesn't have a function (is not a link) and doesn't add content (is not something required to benefit from the article; not a diagram, for instance), we should mark it as decorative with an empty alt attribute. |
|
To me the images are adding content, as they are describing more of what the text indicates. But I don't have strong feelings about it. |
|
@lschatzkin The links in the text are a little hard to see. Could you tweak the links (color?) to make them more legible? |
|
I'm not sure what links you are referring to. |
|
I added a couple of links: |
src/_locales/en_US/messages.json
Outdated
| "description": "Intro page paragraph heading." | ||
| }, | ||
| "intro_learns_paragraph": { | ||
| "message": "The longer you browse with Privacy Badger, the better it gets at protecting you. Is your Badger not blocking anything yet? Instead of keeping lists of what to block, Privacy Badger automatically discovers trackers as you browse the Web. So start browsing a little to teach your Badger.", |
There was a problem hiding this comment.
I might add "That's OK!" after "Is your Badger not blocking anything yet?" Otherwise, the transition can read kind of awkward.
|
I've changed the link color to the darker orange, which still seems light to me. See what you think. If it's not working, I'd consult with Michelle to choose a different color. |
src/_locales/en_US/messages.json
Outdated
| "description": "Intro page paragraph heading." | ||
| }, | ||
| "intro_beyond_ads_paragraph": { | ||
| "message": "Invisible tracking happens in all sorts of ways; ads are just the visible tip of the iceberg. Privacy Badger <a href='https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/DNT' target='_blank'>sends the Do Not Track signal</a> to trackers telling them not to track you. If they ignore your wishes, your Badger will learn to block them—whether they are advertisers or trackers of other kinds.", |
There was a problem hiding this comment.
Should we link to the MDN doc or to our explanation of DNT? https://www.eff.org/issues/do-not-track
Probably regular people will be more interested in the general philosophy than the technical details. It's a long post though. Maybe in the future change that to the FAQ where there is a short explanation.
src/skin/firstRun.html
Outdated
| </div> | ||
| <div id="pb-donate-button" class="align-center"> | ||
| <div class="text-center"> | ||
| <a class="i18n_donate_to_eff button large" href="https://supporters.eff.org/donate/support-privacy-badger"></a> |
There was a problem hiding this comment.
Open in new tab so they can easily still click on the share buttons without having to reopen the tutorial.
|
Tests that have been OK so far for reference:
|
|
Updated source locale in Transifex, synced it back to this PR, then pulled down all other locales. |
Update the new user welcome page.
|
Thanks everyone! |
Fixes #489, fixes #1736.