Upgrade Tweet replacement with surrogate JS API #2926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1393. Following up on #2805 and 4cf0533.
https://developer.twitter.com/en/docs/twitter-for-websites/javascript-api/overview
Examples
Already working and should continue to work
Newly working (alternate embed HTML)
Newly working (using JS API)
Still broken
Forums that use a nested frame from https://github.com/s9e/s9e.github.io/blob/master/iframe/2/twitter.min.html:
Forum that uses https://api.twitter.com/1/statuses/oembed.json?id=XXX&omit_script=true&callback=jQueryYYY_ZZZ&_=QQQ:
Broken display
pulsembed.eu
is unblocked, our replacement is almost completely hidden)