Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tweet replacement with surrogate JS API #2926

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

ghostwords
Copy link
Member

@ghostwords ghostwords commented Nov 28, 2023

Fixes #1393. Following up on #2805 and 4cf0533.

https://developer.twitter.com/en/docs/twitter-for-websites/javascript-api/overview

Examples

Already working and should continue to work

Newly working (alternate embed HTML)

Newly working (using JS API)

Still broken

Forums that use a nested frame from https://github.com/s9e/s9e.github.io/blob/master/iframe/2/twitter.min.html:

Forum that uses https://api.twitter.com/1/statuses/oembed.json?id=XXX&omit_script=true&callback=jQueryYYY_ZZZ&_=QQQ:

Broken display

@ghostwords ghostwords added widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets surrogates Replacement blank/noop/dummy/neutered versions of tracking scripts used to avoid site breakages labels Nov 28, 2023
@ghostwords ghostwords merged commit 8e22c3f into master Nov 29, 2023
2 checks passed
@ghostwords ghostwords deleted the twitter-replacement-v2 branch November 29, 2023 16:19
ghostwords added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
surrogates Replacement blank/noop/dummy/neutered versions of tracking scripts used to avoid site breakages widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle embedded Tweets
1 participant