Skip to content

Fix regex to match quoted parameters in parseParams function #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fadrian06 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix regex to match quoted parameters in parseParams function #209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4646185
Fix regex in parseParams for quoted parameters
fadrian06 Jun 26, 2026
dcca49f
make quotes optional
fadrian06 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/BladeOne.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3033,7 +3033,7 @@ protected function compileComponents($value)

protected function parseParams($params): string
{
preg_match_all('/([a-zA-Z0-9:-]*?)\s*?=\s*?(.+?)(\s|$)/ms', $params, $matches);
preg_match_all('/([a-zA-Z0-9:-]*?)\s*?=\s*?(".+?"|\'.+?\')(\s|$)/ms', $params, $matches);
Comment thread
fadrian06 marked this conversation as resolved.
Outdated
$paramsCompiled = [];
foreach ($matches[1] as $i => $key) {
$value = str_replace('"', '', $matches[2][$i]);
Expand Down