fix: correct session reset mode options in Settings UI#475
Open
GaoZzr wants to merge 9 commits intoEKKOLearnAI:mainfrom
Open
fix: correct session reset mode options in Settings UI#475GaoZzr wants to merge 9 commits intoEKKOLearnAI:mainfrom
GaoZzr wants to merge 9 commits intoEKKOLearnAI:mainfrom
Conversation
- Change 'hourly' to 'daily' to match gateway SessionResetPolicy - Add 'none' option (officially supported in CLI setup wizard) - Add 'modeDaily' and 'modeNone' i18n keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The Session Settings dropdown in the WebUI has two bugs that prevent proper session reset mode configuration:
Bug 1:
hourlyinstead ofdailyThe dropdown uses
value: 'hourly'but the gateway'sSessionResetPolicy(ingateway/config.py) only recognizes"daily","idle","both", and"none". Selecting "Scheduled Only" writesmode: hourlyto config.yaml, which the gateway silently ignores — effectively behaving asmode: none.Bug 2: Missing
noneoptionThe CLI setup wizard (
hermes_cli/setup.py) offers 4 choices including "Never auto-reset (context lives until /reset or context compression)" →mode: none. This is also documented incli-config.yaml.exampleand explicitly handled ingateway/session.py:However, the WebUI dropdown only has 3 options, making it impossible to select
nonethrough the UI.Changes
SessionSettings.vuevalue: 'hourly'→value: 'daily'to match gateway expectations{ label: t('settings.session.modeNone'), value: 'none' }optionmodeDailyi18n key (renamed frommodeHourly)i18n locale files (all 8 languages)
modeHourly→modeDaily(same translations)modeNonetranslation for each language:Impact
none). After this fix, they'll get the intendeddailybehavior.Related
gateway/config.py:SessionResetPolicy— documents 4 modes:"daily","idle","both","none"hermes_cli/setup.py: CLI wizard offers all 4 modescli-config.yaml.example:mode: both # "both", "idle", "daily", or "none"