-
Notifications
You must be signed in to change notification settings - Fork 34
🚧 Rename model to routine in yaml configs #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #211 +/- ##
==========================================
- Coverage 98.10% 98.08% -0.02%
==========================================
Files 175 175
Lines 9165 9184 +19
Branches 1163 1164 +1
==========================================
+ Hits 8991 9008 +17
- Misses 106 107 +1
- Partials 68 69 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @o-laurent. We will have to make sure the documentation is up to date, though, when we remove the baselines.
We can postpone the merging if you think that other matters are more
pressing.
… ***@***.**** approved this pull request.
Looks good to me @o-laurent <https://github.com/o-laurent>. We will have
to make sure the documentation is up to date, though, when we remove the
baselines.
—
Reply to this email directly, view it on GitHub
<#211 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO7X36YSHL25ZZXWBBUBJ2L3LIG2TAVCNFSM6AAAAACCZTH4WSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANZVGMYDGMBUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I think #196 takes precedence. I will work on it this week! |
This solution works, but is surely brittle, and we should probably pin the minor version of
lightning
.lightning
version