Skip to content

Conversation

o-laurent
Copy link
Contributor

@o-laurent o-laurent commented Jul 31, 2025

This solution works, but is surely brittle, and we should probably pin the minor version of lightning.

  • Pin the minor lightning version

@o-laurent o-laurent requested a review from alafage July 31, 2025 11:18
@o-laurent o-laurent self-assigned this Jul 31, 2025
@o-laurent o-laurent added the enhancement New feature or request label Jul 31, 2025
@o-laurent o-laurent marked this pull request as draft July 31, 2025 11:22
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.08%. Comparing base (94af1d5) to head (a62a9b3).
⚠️ Report is 3 commits behind head on dev.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
torch_uncertainty/utils/cli.py 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #211      +/-   ##
==========================================
- Coverage   98.10%   98.08%   -0.02%     
==========================================
  Files         175      175              
  Lines        9165     9184      +19     
  Branches     1163     1164       +1     
==========================================
+ Hits         8991     9008      +17     
- Misses        106      107       +1     
- Partials       68       69       +1     
Flag Coverage Δ
pytest 98.08% <88.23%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alafage alafage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @o-laurent. We will have to make sure the documentation is up to date, though, when we remove the baselines.

@o-laurent
Copy link
Contributor Author

o-laurent commented Jul 31, 2025 via email

@alafage
Copy link
Contributor

alafage commented Jul 31, 2025

We can postpone the merging if you think that other matters are more pressing.

I think #196 takes precedence. I will work on it this week!

@o-laurent o-laurent changed the title 🚧 Rename model to routine in yaml 🚧 Rename model to routine in yaml configs Jul 31, 2025
@o-laurent o-laurent marked this pull request as ready for review July 31, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants