Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooked up the login page and added some context to control redirects. #217

Merged
merged 9 commits into from
Oct 22, 2023
Merged

Hooked up the login page and added some context to control redirects. #217

merged 9 commits into from
Oct 22, 2023

Conversation

igMike-V
Copy link
Collaborator

Login pages now connected.

  • Updated the API server cors declaration to include credentials.
  • Wrapped App in context to give some auth and user state.
  • Added a pre initialized axios instance to force sending credentials
  • Added authService with login, logout, register calls to API
  • Added Registration page
  • Added logout button
  • Redirected logged out users to login page.

This was linked to issues Oct 20, 2023
Login & Signup Pages #190
Closed
Logout UI #191
Closed
0916dhkim
0916dhkim approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@0916dhkim 0916dhkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! It works great, and the code looks good.
Just a few nitpicks + ideas for future iterations.
You can merge as soon as the comments are addressed (except the ones marked "for separate PR")

web/src/Services/authService.tsx Outdated Show resolved Hide resolved
server/src/modules/auth/controller.ts Outdated Show resolved Hide resolved
server/src/index.ts Show resolved Hide resolved
web/src/Components/Shared/Forms/index.tsx Outdated Show resolved Hide resolved
web/src/Components/Shared/context/AuthContext.tsx Show resolved Hide resolved
web/src/Components/Shared/styles/layout.tsx Show resolved Hide resolved
@igMike-V igMike-V merged commit c496af0 into EOT-Event-Organizer-s-Toolbox:main Oct 22, 2023
@igMike-V igMike-V deleted the login branch October 22, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0916dhkim 0916dhkim 0916dhkim approved these changes

@anjolaoluwaakindipe anjolaoluwaakindipe Awaiting requested review from anjolaoluwaakindipe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logout UI Login & Signup Pages
2 participants
@igMike-V @0916dhkim