Roundoff-level mods of prep_glc_map_lnd2glc#633
Open
billsacks wants to merge 2 commits intoESCOMP:mainfrom
Open
Roundoff-level mods of prep_glc_map_lnd2glc#633billsacks wants to merge 2 commits intoESCOMP:mainfrom
billsacks wants to merge 2 commits intoESCOMP:mainfrom
Conversation
This cast to real shouldn't be done since we are assigning an r8 to an r8.
The point of this is to make some minimal changes needed to get bit-for-bit results with an upcoming refactor, in which the elevation factors will be computed separately.
Member
Author
|
Reassigning this to @Katetc as reviewer (rather than @mvertens ) because I just went through it with her (and I don't think this needs multiple reviews). @Katetc - here are some cases if you want to look more closely at the differences: /glade/derecho/scratch/sacks/ERS_Ly7.f09_g17_gris4.T1850Gg.derecho_intel.GC.20260223_065655_ox3af6 /glade/derecho/scratch/sacks/SMS_D_Ly1.f09_g17_ais8.T1850Ga.derecho_gnu.GC.20260223_065655_ox3af6 I compared against baselines in /glade/campaign/cesm/cesmdata/cesm_baselines/cesm3_0_alpha08e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Two roundoff-level modifications of prep_glc_map_lnd2glc to pave the way for a larger set of changes. I wanted to demonstrate that the larger set of changes is bit-for-bit, so here I have implemented the minimal set of answer-changing mods needed to get bit-for-bit results when running tests on my upcoming PR.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) - Single-precision-roundoff-level changes in configurations with CISM or DGLC (though diffs only show up in a small number of tests with DGLC)
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed
In the context of cesm3_0_alpha08e, ran aux_glc plus these additional tests:
Tests passed (other than
FAIL NCK_Ly3.f09_g17_gris20.T1850Gg.derecho_gnu COMPARE_base_multiinstwhich is documented as failing in the CISM ChangeLog). I didn't perform baseline comparisons for most tests, but I expect baseline comparisons to fail for most / all of these tests.I did look at baseline comparisons for
ERS_Ly7.f09_g17_gris4.T1850Gg.derecho_intelandSMS_D_Ly1.f09_g17_ais8.T1850Ga.derecho_gnu. Looking at the cpl hist files, these had just single-precision-roundoff-level diffs, as expected. ForERS_Ly7.f09_g17_gris4.T1850Gg.derecho_intel, for example, these were:Based on testing on my upcoming branch - which effectively includes these changes (along with many other changes) - differences only show up in:
ERS_Ld5.ne30pg3_t232.B1850C_LTso.derecho_intel.allactive-decstartandERS_Ld5.ne30pg3_t232.BHISTC_LTso.derecho_intel.allactive-decstart)