b4b-dev: Allow file paths with length 512

[samsrabin]

Description of changes

Changes some input file paths to be of length SHR_KIND_CX (512) instead of SHR_KIND_CL (256). Also deletes some unused uses of SHR_KIND_CL that were annoying during this work.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

• Resolves long parameter file path string in fates seed dispersal test #2322
• Resolves Change all filepath variables to SHR_KIND_CX (512) #2651
• Resolves Race condition with multiple FatesColdSeedDisp tests #3041

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

• ERS_D_Ld20.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp passes (as of 404b3ca)
• Unit tests pass (as of 1e488d8)
• aux_clm passes (as of 1e488d8)

[ekluzek]

Awesome. Hopefully, this can happen without a hitch. I ran into problems last time I worked on this once we got to 256. But, tons have changed since then and I hope this will just work now.

[ekluzek]

This is awesome. Thanks for working on this and bringing it in. I'm glad we can lengthen our filenames lengths and you got it to work without problems.

I also didn't realize we had a fname_len variable that we should've been using all along, and you made that change. I also like your rename of it to FL, similar to other shr_kind renames.

[samsrabin]

@ekluzek Unfortunately I run into this error in the PEM_D_Ld20.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp test:

WARNING: Test case setup failed. Case2 has been removed, but the main case may be in an inconsistent state. If you want to rerun this test, you should create a new test rather than trying to rerun this one.
ERROR: Command /glade/work/samrabin/ctsm_fix-FatesColdSeedDisp-race/cime/../bld/build-namelist failed rc=255
out=
err=ERROR : CLM build-namelist::CLMBuildNamelist::process_namelist_infile() : Invalid namelist variable in '-infile' /glade/derecho/scratch/samrabin/tests_0409-170738de/PEM_D_Ld20.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.C.0409-170738de_gnu/case2/PEM_D_Ld20.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.C.0409-170738de_gnu/Buildconf/clmconf/namelist.
 ERROR: in validate_variable_value (package Build::Namelist): Variable name fates_paramfile has a string element that is too long: '/glade/derecho/scratch/samrabin/tests_0409-170738de/PEM_D_Ld20.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.C.0409-170738de_gnu/case2/PEM_D_Ld20.5x5_amazon.I2000Clm50FatesRs.derecho_gnu.clm-FatesColdSeedDisp.C.0409-170738de_gnu/fates_params_seeddisp_4x5.nc'

I can't figure out how to increase the maximum string length in the perl, so I'll need your help here.

A test is failing.

[ekluzek]

@samsrabin I pushed a change that should resolve the problem. The character lengths in the namelist_definition_ctsm.xml file for the filenames just needed to be updated. I didn't do anything beyond making the changes that I saw. So you'll need to test and validate, and make sure I didn't screw up syntax or miss something.