-
Notifications
You must be signed in to change notification settings - Fork 18
New procedure for updating .md and .yaml files #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
4027210
13c93a1
05e2c2d
f4a333c
dfa7f88
aafbf99
f42b1dc
4ec3614
64df4e9
3d99bc7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,7 @@ | ||
| name: Render xml standard name dictionary to markdown and yaml and commit to repository | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
|
||
|
|
||
| jobs: | ||
| update-md-and-yaml: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just run
git diffafter line 78 and check the return code?Generally, why do we need this. I would revert the changes to pull_request_ci.yml entirely. Can't we just add a checkbox to the pull request template that instructs the code managers to check if the rendered files need to be updated, run the workflow_dispatch action and then tick the box? See #123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy removing these actions all together and returning to the manual updates of old. It would be nice to have an automatic (or at least push-button) solution to update these tables within GitHub but it could be getting that working seems to be more trouble than it's worth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, yes. Maybe the best approach is a pragmatic one. Your PR has it so that the checks fail because the files must be updated. If we add a big bold message there (and in the documentation) that tells the user to update and commit the files, and how to do it, then that is perfectly fine for me.