Fix convert_xml_to_yaml() function to properly handle nested sections #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
climbfuji
previously approved these changes
Jan 7, 2026
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for fixing this so quickly.
climbfuji
dismissed
their stale review
Dismissing my approval because the script apparently has a bug (CI tests fail, invalid number of function arguments)
nusbaume
approved these changes
Jan 7, 2026
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for the bug fix @mkavulich! Everything looks good to me, although I did have some optional print statement requests.
climbfuji
approved these changes
Jan 8, 2026
Collaborator
Author
|
@climbfuji Pinging to make sure you agree with this change for standard names with no type. |
Collaborator
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version of the
tools/write_standard_name_table.pyscript does not appropriately read nested section elements from the XML when writing a YAML output. I had ChatGPT fix the function to appropriately account for this, then reviewed the results and made some manual tweaks to make the output neater.Links to ChatGPT output:
Issues
Fixes #132