Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests if deprecated ~/.esmvaltool/config-user.yml file is available #2543

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Oct 7, 2024

Description

Fix tests if a deprecated ~/.esmvaltool/config-user.yml file exists on the system.

Closes #2541


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.12.0 milestone Oct 7, 2024
@schlunma schlunma self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (5b28372) to head (a6884af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         251      251           
  Lines       14295    14295           
=======================================
  Hits        13566    13566           
  Misses        729      729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! Is the unwanted behaviour the same for config-developer too?

@schlunma
Copy link
Contributor Author

schlunma commented Oct 7, 2024

config-developer.yml has not been deprecated (yet), so no problems here.

@valeriupredoi
Copy link
Contributor

danke, Manu 🍺

@valeriupredoi
Copy link
Contributor

@bouweandela would you spare a spare rib, I mean minute for a check and merge here pls bud 🍺

@bouweandela bouweandela merged commit 6f34791 into main Oct 7, 2024
7 checks passed
@bouweandela bouweandela deleted the fix_tests_with_old_config branch October 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail if ~/.esmvaltool/config-user.yml file exists
3 participants