Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASIM-5674] - Read uncertainty propagation results #393

Merged
merged 2 commits into from
Jul 23, 2024
Merged

[ASIM-5674] - Read uncertainty propagation results #393

merged 2 commits into from
Jul 23, 2024

Conversation

BeneBr
Copy link
Contributor

@BeneBr BeneBr commented Jul 5, 2024

@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch 8 times, most recently from de4ceed to 28e13f5 Compare July 9, 2024 17:12
@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch from 88c07ee to 39f53a5 Compare July 9, 2024 17:28
@BeneBr BeneBr requested review from prusse-martin, nicoddemus, cauebs and ggrbill and removed request for prusse-martin July 9, 2024 17:38
@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch from 36905be to 1b7dda1 Compare July 9, 2024 18:48
nicoddemus
nicoddemus approved these changes Jul 10, 2024
View reviewed changes
src/alfasim_sdk/result_reader/aggregator.py Show resolved Hide resolved
src/alfasim_sdk/result_reader/aggregator.py Outdated Show resolved Hide resolved
src/alfasim_sdk/result_reader/aggregator.py Outdated Show resolved Hide resolved
ggrbill
ggrbill approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ggrbill ggrbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prusse-martin
prusse-martin approved these changes Jul 11, 2024
View reviewed changes
src/alfasim_sdk/result_reader/aggregator.py Outdated Show resolved Hide resolved
src/alfasim_sdk/result_reader/aggregator.py Outdated Show resolved Hide resolved
@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch from 7b3b642 to 6292031 Compare July 11, 2024 16:52
@BeneBr BeneBr requested a review from ro-oliveira95 July 11, 2024 16:55
ro-oliveira95
ro-oliveira95 approved these changes Jul 11, 2024
View reviewed changes
src/alfasim_sdk/result_reader/aggregator.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/results/test_aggregator.py Outdated Show resolved Hide resolved
@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch from 7ee4df9 to 6292031 Compare July 11, 2024 21:44
@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch 5 times, most recently from e05b705 to 7e0aa61 Compare July 23, 2024 23:17
@BeneBr BeneBr force-pushed the fb-ASIM-5674-read-uncertainty-propagation-results branch from a2acbe3 to 6943130 Compare July 23, 2024 23:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BeneBr BeneBr merged commit c7572bf into master Jul 23, 2024
12 checks passed
@BeneBr BeneBr deleted the fb-ASIM-5674-read-uncertainty-propagation-results branch July 23, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro-oliveira95 ro-oliveira95 ro-oliveira95 approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

@ggrbill ggrbill ggrbill approved these changes

@prusse-martin prusse-martin prusse-martin approved these changes

@cauebs cauebs Awaiting requested review from cauebs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BeneBr @nicoddemus @prusse-martin @ro-oliveira95 @ggrbill