Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a possibility to plugin user gets wall properties #398

Merged
merged 21 commits into from
Aug 28, 2024
Merged

Add a possibility to plugin user gets wall properties #398

merged 21 commits into from
Aug 28, 2024

Conversation

alexandrebbruno
Copy link
Member

PR description:

  • Adds get_wall_properties, the method that a plugin developer user will use to get wall properties.

ggrbill
ggrbill requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@ggrbill ggrbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Please, check the appearance of the new documentation.

src/alfasim_sdk/alfasim_sdk_api/api.h Outdated Show resolved Hide resolved
src/alfasim_sdk/alfasim_sdk_api/api.h Outdated Show resolved Hide resolved
prusse-martin
prusse-martin approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@prusse-martin prusse-martin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some documentation updates.

src/alfasim_sdk/alfasim_sdk_api/api.h Outdated Show resolved Hide resolved
src/alfasim_sdk/alfasim_sdk_api/api.h Outdated Show resolved Hide resolved
src/alfasim_sdk/alfasim_sdk_api/api.h Outdated Show resolved Hide resolved
src/alfasim_sdk/alfasim_sdk_api/detail/api_pointers.h Outdated Show resolved Hide resolved
@alexandrebbruno alexandrebbruno force-pushed the fb-ASIM-5688-exporting-variables-APB-plugin branch from 674395e to 893528f Compare August 27, 2024 11:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexandrebbruno alexandrebbruno merged commit 0220420 into master Aug 28, 2024
12 checks passed
@alexandrebbruno alexandrebbruno deleted the fb-ASIM-5688-exporting-variables-APB-plugin branch August 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caio-ramos caio-ramos caio-ramos approved these changes

@ThalesCarl ThalesCarl ThalesCarl approved these changes

@ggrbill ggrbill ggrbill approved these changes

@eniohayashi eniohayashi eniohayashi approved these changes

@prusse-martin prusse-martin prusse-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexandrebbruno @prusse-martin @eniohayashi @ggrbill @ThalesCarl @caio-ramos