Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger capability to plugins developers #399

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

alexandrebbruno
Copy link
Member

PR description:

  • It allows the plugin developer to add warning and information messages to the calc solver.

https://esss.atlassian.net/browse/ASIM-5645

Copy link
Contributor

@ThalesCarl ThalesCarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯

docs/source/plugins/99_1_solver_api_reference.rst Outdated Show resolved Hide resolved
src/alfasim_sdk/alfasim_sdk_api/api.h Outdated Show resolved Hide resolved
@eniohayashi
Copy link
Contributor

eniohayashi commented Sep 2, 2024

I think you could also update the Changelog.rst.

Copy link
Member

@ggrbill ggrbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

src/alfasim_sdk/alfasim_sdk_api/api.h Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link
Contributor

@eniohayashi eniohayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@alexandrebbruno alexandrebbruno merged commit 07b841f into master Sep 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants