Make get_wall_material_names return material name for one layer id #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThalesCarl
approved these changes
Sep 26, 2024
eniohayashi
approved these changes
Sep 26, 2024
# Conflicts: # src/alfasim_sdk/alfasim_sdk_api/api.h # src/alfasim_sdk/alfasim_sdk_api/detail/api_pointers.h # src/alfasim_sdk/alfasim_sdk_api/detail/bootstrap_linux.h # src/alfasim_sdk/alfasim_sdk_api/detail/bootstrap_win.h
|
| @return An #error_code value. | ||
| */ | ||
| DLL_EXPORT int get_wall_material_names(void* ctx, char*** material_names_in_wall, int control_volume_id, int* size); | ||
| DLL_EXPORT int get_wall_material_name(void* ctx, char** material_name, int control_volume_id, int layer_id); |
There was a problem hiding this comment.
Was the old signature already released?
I ask because if it did be released this will probably cause a binary incompatibility. No?
The API has been broken, but that is kind of "OK". The next release will change major version to indicate we are moving back to semantic versioning. Otherwise major version update would be required to indicate we did break the old API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Solution: make the get_wall_material_name only return one wall name at once, by making the user provide the layer_id.