For GCC10, check __cplusplus >= 201709 for c++20 support #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… c++20 is supported
|
Review changes with SemanticDiff. |
jwellbelove
pushed a commit
that referenced
this pull request
Aug 31, 2024
… c++20 is supported (#949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From here: https://godbolt.org/z/n967rrMGY you can see that using GCC 10 and compiling with -stdc++=20 that __cplusplus evaluates to 201709. Switching to GCC 11, it evaluates to 202002.
This was problematic in our build as ETL_CPP20_SUPPORTED was not being detected correctly and we were having issues with redefinition of char8_t. Tried to workaround by setting ETL_NO_SMALL_CHAR_SUPPORT=0, however parts of our build use -stdc++=17 which would then fail with this flag due to missing definition of char8_t.