Feature: add Linux_Systemd_Rauc module #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
commented
Sep 10, 2025
| // get_boot_slot() should be more reliable since it indicates the slot | ||
| // we booted from. This will change on a successful OTA + reboot | ||
|
|
||
| std::string cmd = "/usr/bin/check_system_health.sh"; |
There was a problem hiding this comment.
@james-ctc is this a file we may want to check in as part of the module and/or make the path to it configurable?
There was a problem hiding this comment.
I recommend making it a configuration item with an empty default.
/usr/bin/check_system_health.sh was provided in a Yocto meta layer. Changing to a config item removes that dependency.
|
TODO: add sdbus requirement to ci build kit image |
james-ctc
reviewed
Sep 11, 2025
Pietfried
force-pushed
the
feature/add-linux-systemd-rauc
branch
from
89cb769 to
bf19be9
Compare
Pietfried
requested review from
hikinggrass,
corneliusclaussen,
SebaLukas,
andistorm and
mlitre
as code owners
|
@james-ctc addressed all comments, can be re-reviewed |
james-ctc
reviewed
Sep 11, 2025
james-ctc
previously approved these changes
Sep 12, 2025
james-ctc
force-pushed
the
feature/add-linux-systemd-rauc
branch
from
9f32579 to
099430e
Compare
|
hikinggrass
requested changes
Sep 29, 2025
james-ctc
requested changes
Sep 29, 2025
Signed-off-by: Cornelius Claussen <[email protected]> Adding sdbus-c++ dependecy in cmake for module Linux_Systemd_Rauc (uncomment) Signed-off-by: Florin Mihut <[email protected]> * Reboot and mark-good * removed mark good script. Cleanup. mark good is handled in init() via Systemd Signed-off-by: Cornelius Claussen <[email protected]> * Extension of API for OTA update Signed-off-by: Jan Christoph Habig <[email protected]> Linux_systemd_rauc: Add compatibility with sdbus-c++ 2.x API (#186) Signed-off-by: Cornelius Claussen <[email protected]> feat: added new interface rauc_status that provides percentage (#246) completion during a RAUC install fix: added sdbus-c++ to build Signed-off-by: James Chapman <[email protected]> Cc 13 react to new req system restart messages new (#267) * refactor: extract mechanism for safely calling system commands into companion lib * Add C++ interface to safe_system mechanism * Use safe_system mechanism to implement different types of reset * Address minor issues from PR discussion * Made errno->string conversion thread-safe again. * Use safer mechanism to call external executable in Rauc module * Improve interfaces of companion functions for safe calling of system functions * Make safe_system_c an internal function * Add function to print commands for logging * Handle timeout in safe_system commands and add verbose return type * Fix clang-format * Fix namespace formatting Signed-off-by: Christoph Burandt <[email protected]> feat: add event queue so that modules can request actions from feat: RAUC updates now via event queue fix: SIGCHILD handler not correctly configured fix: updated reboot command OCPP OTA uses the RAUC primary to determine when an OTA was successfully booted - in testing this was not always reliable. The boot slot is more reliable and if it changes after a reboot then that is a good indication that the OTA worked. The updates mean that the OCPP OTA could have a different approach if needed. This implementation supports a migration from using primary slot to using boot slot. feat: save boot and promary slot for OTA checking fix: fixes during testing The System module has code that performs OTA via RAUC's dbus interface. The code has been updated so that a base class performs most operations and the EVerest module specific requirements are now in a derived class. fix: libev now working with sdbus-c++ for RAUC feat: building code + tests with updated companion library feat: factor out common dbus functions feat: implement systemd dbus capability feat: updated sdbus-c++ to support Aync calls for version 1.6 and 2.1.0 Signed-off-by: James Chapman <[email protected]> Move into modules/Misc/Linux_Systemd_Rauc Added system lib to lib/everest Linking Linux_Systemd_Rauc against everest::system Removed provides of rauc interface Removed rauc status types dependency and changed to system types. ADjusted signal_firwmare_update_status signal Added VerifyUpdateScriptPath config parameter and James Chapman as module author Using VerifyUpdateScriptPath config param to decide if an update can be marked as good fixed typo and updated documentation about sdbus version Signed-off-by: Piet Gömpel <[email protected]> Install sdbus-c++ v2.1.0 from source in EDM mode Run apt update before installing libsystemd-dev dependency Fix linkage to sdbus-c++ Use run_application() wrapper for boost process This fixes build on opensuse Include N01.FR.20 fix in Linux_Systemd_Rauc module Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
force-pushed
the
feature/add-linux-systemd-rauc
branch
from
62474fb to
3e249b2
Compare
hikinggrass
changed the title
hikinggrass
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds the Linux_Systemd_Rauc module . It implements the
systeminterface using rauc and base linux system commands.The module requires a custom library for safe system commands, rauc and sdbus. This has been added as part of this PR to lib/everest/system
Issue ticket number and link
Checklist before requesting a review