Add Huawei_V100R023C10 PowerSupply driver #1593
Merged
+19,131
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
cburandt,
corneliusclaussen and
hikinggrass
as code owners
Pietfried
force-pushed
the
feature/add-huawei-v100
branch
from
5a586fb to
75766fa
Compare
Pietfried
force-pushed
the
feature/add-huawei-v100
branch
3 times, most recently
from
bd87836 to
eac4719
Compare
corneliusclaussen
previously approved these changes
Dec 5, 2025
markxoe
reviewed
Dec 5, 2025
Contributor
markxoe
left a comment
markxoe
left a comment
There was a problem hiding this comment.
Also, ev_add_module(Huawei_V100R023C10) is missing in modules/HardwareDrivers/PowerSupplies/CMakeLists.txt
modules/HardwareDrivers/PowerSupplies/Huawei_V100R023C10/Huawei_V100R023C10.cpp
Outdated
Show resolved
Hide resolved
hikinggrass
requested changes
Dec 5, 2025
Member
hikinggrass
left a comment
hikinggrass
left a comment
There was a problem hiding this comment.
I think most/all of the review comments from #1336 still apply here (things like too high CMake versions / C++20 usage etc)
hikinggrass
requested changes
Dec 5, 2025
...pplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/CMakeLists.txt
Outdated
Show resolved
Hide resolved
...pplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/CMakeLists.txt
Outdated
Show resolved
Hide resolved
5 tasks
markxoe
reviewed
Dec 9, 2025
Contributor
markxoe
left a comment
markxoe
left a comment
There was a problem hiding this comment.
This should fix all C++ downgrade compile errors. Has been tested against the user acceptance tests
...rge-driver/libs/fusion_charger_modbus_driver/include/fusion_charger/modbus/registers/raw.hpp
Outdated
Show resolved
Hide resolved
...ies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/lib/dispenser.cpp
Outdated
Show resolved
Hide resolved
markxoe
reviewed
Dec 9, 2025
...rge-driver/libs/fusion_charger_modbus_driver/include/fusion_charger/modbus/registers/raw.hpp
Show resolved
Hide resolved
corneliusclaussen
previously approved these changes
Dec 11, 2025
markxoe
reviewed
Dec 11, 2025
...werSupplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/README.md
Outdated
Show resolved
Hide resolved
...werSupplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/README.md
Outdated
Show resolved
Hide resolved
...werSupplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/README.md
Outdated
Show resolved
Hide resolved
...werSupplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/README.md
Outdated
Show resolved
Hide resolved
...upplies/Huawei_V100R023C10/fusion_charger_lib/huawei-fusioncharge-driver/auffaelligkeiten.md
Outdated
Show resolved
Hide resolved
hikinggrass
requested changes
Dec 11, 2025
modules/HardwareDrivers/PowerSupplies/Huawei_V100R023C10/Huawei_V100R023C10.cpp
Outdated
Show resolved
Hide resolved
modules/HardwareDrivers/PowerSupplies/Huawei_V100R023C10/connector_base/base.cpp
Outdated
Show resolved
Hide resolved
modules/HardwareDrivers/PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/.clang-format
Outdated
Show resolved
Hide resolved
...upplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/.clang-format
Outdated
Show resolved
Hide resolved
...pplies/Huawei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/CMakeLists.txt
Outdated
Show resolved
Hide resolved
...erSupplies/Huawei_V100R023C10/fusion_charger_lib/modbus-server/libs/registers/CMakeLists.txt
Outdated
Show resolved
Hide resolved
Comment on lines
118
to
137
| uint8_t sys_buffer[buffer_size]; | ||
| uint8_t net_buffer[buffer_size]; | ||
|
|
||
| // read the current value and convert it to network byte order | ||
| data_provider.on_read(sys_buffer, buffer_size); | ||
| converter.sys_to_net(sys_buffer, net_buffer, buffer_size); | ||
|
|
||
| // write the new data to the buffer | ||
| memcpy(net_buffer + byte_offset, data.data(), | ||
| std::min(data.size(), sizeof(net_buffer) - byte_offset)); | ||
|
|
||
| // convert the buffer back to system byte order and write it to the provider | ||
| converter.net_to_sys(net_buffer, sys_buffer, buffer_size); | ||
| data_provider.on_write(sys_buffer, buffer_size); | ||
| } | ||
|
|
||
| std::vector<uint8_t> on_read() override { | ||
| std::vector<uint8_t> net_buffer(buffer_size); | ||
|
|
||
| uint8_t sys_buffer[buffer_size]; |
...PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/modbus-server/libs/server/CMakeLists.txt
Outdated
Show resolved
Hide resolved
.../HardwareDrivers/PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/modbus-server/readme.md
Outdated
Show resolved
Hide resolved
.../HardwareDrivers/PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/modbus-server/readme.md
Outdated
Show resolved
Hide resolved
Pietfried
force-pushed
the
feature/add-huawei-v100
branch
2 times, most recently
from
4259042 to
4abeafc
Compare
Contributor
Author
|
Addressed most of the comments, except for the ones regarding the usage of std::array. I'd prefer to handle those in a subsequent PR, as the current changeset relative to the original driver has already become very large and I am likely not able to verify all of these changes. |
hikinggrass
previously approved these changes
Dec 12, 2025
...ei_V100R023C10/fusion_charger_lib/fusion-charger-dispenser-library/include/configuration.hpp
Outdated
Show resolved
Hide resolved
...wareDrivers/PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/modbus-server/CMakeLists.txt
Outdated
Show resolved
Hide resolved
...PowerSupplies/Huawei_V100R023C10/fusion_charger_lib/modbus-server/libs/client/CMakeLists.txt
Outdated
Show resolved
Hide resolved
hikinggrass
approved these changes
Dec 12, 2025
Signed-off-by: Mark Oude Elberink <[email protected]> Signed-off-by: corneliusclaussen <[email protected]> Co-authored-by: Fabian Gajek <[email protected]> Co-authored-by: Kai Hermann <[email protected]> Co-authored-by: Tim <[email protected]> ---------- Additional changes when this driver was moved from BaseCamp to EVerest: * Replaced usage of designated initializers * Removed gitlab ci files * Replace README with doc.rst * Remove Auffaeligkeiten and renamed readme.md to README.md * Use std:: prefixed integer types * Remove clang format files * Removed unused files * Removed code that was commented out * Use modern instead of c-style casts * Refactor CMakeLists: Refactor test setup and register libraries with ev_register_library_target to include those in EVerest coverage generation * Renamed and refactored library README to address the updated CMake structure. The module internally libraries can currently not be built standalone Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
feature/add-huawei-v100
branch
from
c9bf39b to
81ed812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the Huawei_V100R023C10 PowerSupply driver from BaseCamp
Issue ticket number and link
Checklist before requesting a review