Skip to content

Conversation

@Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Dec 2, 2025

Describe your changes

  • Subscribing to powermeter public key and call set_powermeter_public_key at the ChargePoint when it is recieved
  • Added e2e test case for powermeter public key configuration requests

Issue ticket number and link

Companion PR: EVerest/libocpp#1161

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

…rmeter_public_key at the ChargePoint when it is recieved

Added e2e test case for powermeter public key

Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried Pietfried force-pushed the feature/ocpp-powermeter-public-key branch from 7d6d3cb to e16da66 Compare December 10, 2025 11:22
@Pietfried Pietfried marked this pull request as ready for review December 10, 2025 11:22
Copy link
Contributor

@mlitre mlitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the one question everything looks good to me!

@Pietfried Pietfried enabled auto-merge December 11, 2025 08:28
@Pietfried Pietfried requested a review from mlitre December 11, 2025 08:28
libocpp:
git: https://github.com/EVerest/libocpp.git
git_tag: 2c727f86e9ff988bdf13fcf5b049f0d5c3650384
git_tag: 52a347e8d9fe3c0b914945d9946f51724ae2aa76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could probably just put the tag

Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried Pietfried added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 48f939e Dec 11, 2025
10 of 12 checks passed
@Pietfried Pietfried deleted the feature/ocpp-powermeter-public-key branch December 11, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants