Fix unexpected d-link action in case of an error #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaHaGit
requested review from
Pietfried,
SebaLukas,
corneliusclaussen,
hikinggrass,
james-ctc and
mlitre
as code owners
FaHaGit
force-pushed
the
fix/unexpected_dlink_action
branch
from
8a1bf42 to
5c6aa40
Compare
Additionally, improved the naming of the elements and class member. Signed-off-by: Fabian Hartung <[email protected]> EvseV2G: Set default d_link_action to D_LINK_ACTION_TERMINATE Removed the unused D_LINK_ACTION_ERROR and made D_LINK_ACTION_TERMINATE the new default value after initilization of the "conn" structure. This commit solves the issue that d_link_action is not correctly configured to D_LINK_ACTION_TERMINATE when a session ends unexpectedly without SessionStop (before lingered on D_LINK_ACTION_ERROR). Signed-off-by: Fabian Hartung <[email protected]>
FaHaGit
force-pushed
the
fix/unexpected_dlink_action
branch
from
5c6aa40 to
ae84401
Compare
Contributor
Author
|
I squashed the commits |
Contributor
Author
|
@SebaLukas What I forgot to ask in the working group. Can we merge this pull request or do you want to review it first. |
SebaLukas
approved these changes
Dec 10, 2025
Member
|
Sry I had a look into your PR last week but did not click on approved 🙈 I added it to the merge queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently, as soon as V2G communication is unexpectedly terminated by a failed response code and the EV does not send a SessionStopReq, the dlink action parameter is incorrectly left at the initial value "dlink_error". This means that a connected EvseManager is not notified when V2G communication is terminated in this error case. However, the enum value dlink_error does not make sense within the EvseV2G module, as a data-link error cannot be detected by this module.
Issue ticket number and link
Checklist before requesting a review