RsPaymentTerminal: Do not authorize bank cards in backoffice #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wku12
requested review from
Pietfried,
SirVer,
dorezyuk and
hikinggrass
as code owners
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
feat/use_different_IdTokenType_for_bank_cards
branch
from
8efda31 to
68a1556
Compare
ydankner
approved these changes
Dec 4, 2025
| value: id_token, | ||
| r#type: IdTokenType::Local, | ||
| r#type: match authorization_type { | ||
| AuthorizationType::BankCard => IdTokenType::NoAuthorization, |
Contributor
There was a problem hiding this comment.
A comment on NoAuthorization if you feel like it
Contributor
|
I think we should change Rfid to the correct iso value and change bank cards to be "Local". The Ocpp 2.1 defines the authorzation type DirectPayment which is designed for bank cards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When using OCPP to communicate with backoffice, the Authorize message contains only IdTokenType and Value which makes it impossible to distinguish between RFID and BankCards on the backoffice.
The solution for that is to set IdTokenType to NoAuthorization when the provided token was already authorized by the station itself
Issue ticket number and link
Checklist before requesting a review