Additional everestpy runtime settings ctor #232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…logging configuration directly Signed-off-by: Kai-Uwe Hermann <[email protected]>
…sion ctor that accepts config file Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
commented
Jan 8, 2025
Comment on lines
+26
to
+27
| Everest::Logging::init(session.get_logging_config_file().string(), module_id); | ||
|
|
Member
Author
There was a problem hiding this comment.
This is debatable, since logging should not happen before this is called. There's one edge-case where logging might happen earlier: in the deprecated RuntimeSession ctor ManagerSettings could log if something goes wrong
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional RuntimeSettings ctor to everestpy that accepts a MQTTSettings object
This allows eg. everest-testing to directly set the required MQTT connectivity information without having to specify environment variables.
Move init of logging into Module ctor since the module id is only available there