- 
                Notifications
    
You must be signed in to change notification settings  - Fork 16
 
Add SessionSetup to EV side state machine #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/adding-ev-d20
Are you sure you want to change the base?
Add SessionSetup to EV side state machine #155
Conversation
Signed-off-by: Roger Bedell <[email protected]>
Signed-off-by: Roger Bedell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments.
Plus for the session_setup state:
At the moment, it is sufficient if the EV does not support pause/resume.
Pause/resume can be added relatively easily afterwards.
I have roughly written down how I imagine the process in this state:
- Check ResponseCode -> Evse old session joined or OK_NewSession
 - Check session id -> like validate_and_setup_header() in https://github.com/EVerest/libiso15118/blob/main/src/iso15118/d20/context_helper.cpp#L30
 - Check if the chargers wants to join an old session with the response code and not with the ctx session session_id
-> Check Cert session id hash - Create Req
-> AuthSetupReq or
-> Ac/DcChargeParameterDiscovery 
| if (not charger_cert_hash.has_value()) { | ||
| logf_error( | ||
| "No charger certificate hash available although an old session was resumed. Abort the session."); | ||
| m_ctx.stop_session(true); // Tell stack to close the tcp/tls connection | ||
| return {}; | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case the ev can also go to AuthSetup and treat this as a new session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the standard mean terminating the old session. And starting a new one.
I think in this case the ev should start a new session. The charger should handle this.
Signed-off-by: Roger Bedell <[email protected]>
          
 @cienporcien Did you check my last reply?  | 
    
          
 Hi Sebastian,  | 
    
…and lack of EOFs. Signed-off-by: Roger Bedell <[email protected]>

Describe your changes
Add SessionSetup to EV side state machine
Issue ticket number and link
#138
Checklist before requesting a review