Skip to content

Conversation

@bumstone
Copy link
Collaborator

@bumstone bumstone commented May 1, 2025

๐Ÿ“Œ ๋ชฉ์ 

์ด PR์ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๋‚˜ ์ถ”๊ฐ€ํ•˜๋ ค๋Š” ๊ธฐ๋Šฅ์˜ ๋ชฉ์ ์„ ๊ฐ„๋‹จํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.
๊ฒ€์ƒ‰ ๊ธฐ๋ก ์ €์žฅ, ์ตœ์‹  ๊ธฐ๋ก ํ˜ธ์ถœ, ๊ฐœ๋ณ„ ๋ฐ ์ „์ฒด ์‚ญ์ œ ๊ธฐ๋Šฅ

๐Ÿ› ๏ธ ์ž‘์—… ์ƒ์„ธ ๋‚ด์šฉ

์ž‘์—…ํ•œ ๋‚ด์šฉ์— ๋Œ€ํ•œ ์„ค๋ช…์„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ํ˜•์‹์œผ๋กœ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

  • ๊ฒ€์ƒ‰ ๊ธฐ๋ก ์ €์žฅ
  • ์ตœ์‹  ๊ฒ€์ƒ‰ ๊ธฐ๋ก ํ˜ธ์ถœ
  • ๊ฐœ๋ณ„ ๋ฐ ์ „์ฒด ์‚ญ์ œ ๊ธฐ๋Šฅ
  • ๊ฒ€์ƒ‰ ์œ ํšจํ•œ ์—ฐ์‚ฐ์ž๋กœ ๋ณ€๊ฒฝ

๐Ÿ” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

์ฝ”๋“œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์š”์•ฝํ•˜๊ณ  ์ค‘์š”ํ•œ ๋ถ€๋ถ„์„ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

  • ์˜ˆ: UserService ํด๋ž˜์Šค์— ์ƒˆ๋กœ์šด ๋ฉ”์„œ๋“œ ์ถ”๊ฐ€

โœ… ํ…Œ์ŠคํŠธ ๋ฐฉ๋ฒ•

๋ณ€๊ฒฝ๋œ ์ฝ”๋“œ๊ฐ€ ์–ด๋–ป๊ฒŒ ํ…Œ์ŠคํŠธ๋˜์—ˆ๋Š”์ง€ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

  1. ํ…Œ์ŠคํŠธ ์ผ€์ด์Šค ์ž‘์„ฑ
  2. ๋กœ์ปฌ ํ™˜๊ฒฝ์—์„œ ์ง์ ‘ ํ…Œ์ŠคํŠธ
  3. ๊ธฐํƒ€:

โš ๏ธ ์ฃผ์˜ ์‚ฌํ•ญ

์ฝ”๋“œ ๋ณ€๊ฒฝ ์‹œ ๊ณ ๋ คํ•ด์•ผ ํ•  ์ ์ด๋‚˜ ๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ฃผ์˜ํ•ด์•ผ ํ•  ์ ์ด ์žˆ์œผ๋ฉด ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ ์‚ฌํ•ญ)

๋ณ€๊ฒฝ๋œ ๊ธฐ๋Šฅ์ด ์žˆ์œผ๋ฉด ์Šคํฌ๋ฆฐ์ƒท์ด๋‚˜ ๋™์˜์ƒ์„ ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿ”— ์ฐธ๊ณ  ์‚ฌํ•ญ

๊ด€๋ จ๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์–ธ๊ธ‰ํ•ด์ฃผ์„ธ์š”. ์ถ”๊ฐ€ ์ฐธ๊ณ ํ•  ๋งŒํ•œ ์ž๋ฃŒ๋‚˜ ๋งํฌ๊ฐ€ ์žˆ์œผ๋ฉด ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

@bumstone bumstone added bug Something isn't working feat Good for newcomers labels May 1, 2025
@bumstone bumstone self-assigned this May 1, 2025
@bumstone bumstone merged commit 4e7a652 into dev May 1, 2025
1 check passed
@bumstone bumstone deleted the feat/#54-search_history branch May 8, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feat Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants