Skip to content

Add /cmap command #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2025
Merged

Add /cmap command #472

merged 5 commits into from
Apr 18, 2025
+316 −0

Conversation

wagyourtail
Copy link
Contributor

@wagyourtail wagyourtail commented Dec 10, 2022 •
edited
Loading

save held map to file

xpple
xpple requested changes Dec 10, 2022
View reviewed changes
Copy link
Collaborator

@xpple xpple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool command, just a few code style changes mostly.

@xpple
Copy link
Collaborator

xpple commented Jan 8, 2023

I still like @haykam821's suggestion of extending the functionality of this command to maps you are looking at. Should I open a separate issue for that?

@wagyourtail
Copy link
Contributor Author

he can pr that xd

@wagyourtail
Copy link
Contributor Author

that was much harder than expected but it works

@wagyourtail wagyourtail requested review from xpple, Earthcomputer and haykam821 and removed request for Earthcomputer and xpple January 9, 2023 03:52
@wagyourtail
Copy link
Contributor Author

wait, since when can I not request multiple reviews

xpple
xpple requested changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@xpple xpple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style changes.

@xpple xpple added the enhancement New feature or request label Jul 3, 2023
@haykam821
Copy link
Collaborator

Is this pull request still maintained? The functionality can be extended in a later pull request to include #399 and #400.

@wagyourtail
Copy link
Contributor Author

wagyourtail commented Mar 24, 2025 •
edited
Loading

Is this pull request still maintained? The functionality can be extended in a later pull request to include #399 and #400.

I think that would be more suited to a more general command to get the nbt of a held item.
that wouldn't nicely format it, but it'd be more useful.

or is that not stored there anymore

@wagyourtail
Copy link
Contributor Author

wagyourtail commented Mar 25, 2025 •
edited
Loading

I guess since cgetdata doesnt return it for entity @s SelectedItem it doesn't.

I think I'll leave /cmap info for someone else to implement

@wagyourtail wagyourtail requested a review from xpple April 7, 2025 21:34
xpple
xpple approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@xpple xpple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xpple xpple changed the title cmap Add /cmap command Apr 7, 2025
@Earthcomputer Earthcomputer merged commit c5afffc into Earthcomputer:fabric Apr 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haykam821 haykam821

@Earthcomputer Earthcomputer

@xpple xpple

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wagyourtail @xpple @haykam821 @Earthcomputer