Skip to content

for list comprehension of train_history #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BernhardAhrens wants to merge 1 commit into
base: main
Choose a base branch
from
Open

for list comprehension of train_history #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/wrap_tuples.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ struct WrappedTuples{T <: AbstractVector{<:NamedTuple}} <: AbstractVector{NamedT
end

# Required methods for AbstractVector
Base.size(w::WrappedTuples) = (length(w.data), length(first(w.data)))
Copy link
Member

@lazarusA lazarusA Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this.

The intended use of this is to first do something like soc = WrappedTuples(SOC.history), and then soc.nse to get all values, without the need to use list comprehension.

Copy link
Collaborator Author

@BernhardAhrens BernhardAhrens Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EasyHybrid.jl/src/utils/wrap_tuples.jl

Line 8 in 841c7e6

struct WrappedTuples{T <: AbstractVector{<:NamedTuple}} <: AbstractVector{NamedTuple}

It's also just odd to have an 2D vector 😆

Base.size(w::WrappedTuples) = (length(w.data),)
Base.getindex(w::WrappedTuples, i::Int) = w.data[i]
Base.getindex(w::WrappedTuples, r::AbstractRange) = WrappedTuples(w.data[r])
Base.IndexStyle(::Type{<:WrappedTuples}) = IndexLinear()
Expand Down
Loading