Skip to content

Conversation

@blackWins
Copy link
Collaborator

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a visibility filter so only settings marked as visible to clients are processed/exposed, and updates the sample app to demonstrate the new behavior with appropriate setting definitions and localization.

  • Apply IsVisibleToClients filter in SettingUiAppService
  • Mark sample settings with isVisibleToClients and add a hidden sample setting
  • Add localization entries for the new sample setting

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/EasyAbp.Abp.SettingUi.Application/SettingUiAppService.cs Filters out settings not visible to clients before creating SettingInfo.
sample/MyAbpApp/src/MyAbpApp.Domain/Settings/MyAbpAppSettings.cs Adds BSettings.Setting2 constant used by the sample provider.
sample/MyAbpApp/src/MyAbpApp.Domain/Settings/MyAbpAppSettingDefinitionProvider.cs Sets isVisibleToClients on several settings and introduces a hidden setting (BSettings.Setting2).
sample/MyAbpApp/src/MyAbpApp.Domain.Shared/Localization/MyAbpApp/en.json Adds DisplayName for BSettings.Setting2.
sample/MyAbpApp/src/MyAbpApp.Domain.Shared/Localization/MyAbpApp/zh-Hans.json Adds DisplayName for BSettings.Setting2.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

//this setting is not visible to clients
new SettingDefinition(
MyAbpAppSettings.SettingExample.BSettings.Setting2,
"setting 2 value")
Copy link

Copilot AI Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the comment and be explicit like the other definitions, pass isVisibleToClients: false in the constructor. This makes the intent clear and avoids relying on a default value.

Suggested change
"setting 2 value")
"setting 2 value",
isVisibleToClients: false)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant