Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Drop, add support for .NET versions #527

Merged
merged 6 commits into from
Nov 30, 2023
Merged

[chore] Drop, add support for .NET versions #527

merged 6 commits into from
Nov 30, 2023

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Nov 30, 2023 •
edited
Loading

Description

  • Drop support for .NET Core 3.1
  • Add support for .NET 8.0
  • Set C# syntax to latest
  • Suppress .NET 8.0 style warning (will be suppressed by style guide in later PR)
  • Update setup scripts for new frameworks

Testing

  • All unit tests pass, no cassette alterations needed
  • Will need to update GitHub CI version matrix

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8
- Drop support for .NET Core 3.1, .NET 5.0
57ad3d9 
- Add support for .NET 8.0
- Set C# syntax to latest
- Suppress .NET 8.0 style warning (will be suppressed by styleguide in later PR)
- Update setup scripts for new frameworks
@nwithan8 nwithan8 requested review from a team, jchen293 and Justintime50 November 30, 2023 00:51
Justintime50
Justintime50 reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are keeping with our policy, we should continue to support 5.0 because it's the last deprecated version. If we remove it, we won't have any deprecated versions supported. Technically that's true of 3.1 as well. I'd suggest we just add support for 8?

@nwithan8 nwithan8 marked this pull request as draft November 30, 2023 20:19
@nwithan8
Copy link
Contributor Author

nwithan8 commented Nov 30, 2023 •
edited
Loading

CI is complaining about style guide violations (for rules that don't exist), even though it's not complaining locally...

EDIT: The bug exists in ReSharper, so my Rider IDE? That doesn't make sense...
dotnet/roslyn#70816

@nwithan8 nwithan8 marked this pull request as ready for review November 30, 2023 20:34
@nwithan8 nwithan8 merged commit cf307b8 into master Nov 30, 2023
14 checks passed
@nwithan8 nwithan8 deleted the versions branch November 30, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50