Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Instance usage of get_payment_method_info in billing service #296

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Jan 20, 2024

Description

As pointed out in #295 , a helper method in our billing service was static rather than instance-based, causing issues when calling it.

This PR makes the method a private instance helper method (not for end-user consumption), and updates the associated unit tests.

Closes #295

Testing

  • Unit test updated, no cassettes need to be rerecorded (test was already mock-only)

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team January 20, 2024 02:34
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"How was this not caught"

Ah yes, mocking...

Copy link
Contributor

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a changelog

@nwithan8 nwithan8 merged commit af3d9e0 into master Jan 23, 2024
7 checks passed
@nwithan8 nwithan8 deleted the fund_wallet branch January 23, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: undefined method `retrieve_payment_methods' for class EasyPost::Services::Billing
3 participants