Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Reformed: Profile/README.md #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AnadyaNair
Copy link

@AnadyaNair AnadyaNair commented Dec 28, 2021

This pull request introduces the following changes:

  • A banner included at the start of the file.
  • A description about EddieHub organisation, Eddie's believes, and this place is welcome to all.
  • Links redirecting to Eddie's YouTube channel, Eddie's courses, raising issues for joining, Discord community.
  • A hello to the mascot - Hubber.
  • FAQs discussing 7 topics (redirect links included).

A preview of the reformed README.md can be seen on my forked repository for ease.

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add that much content to the org page.
+ For QnA, we have our support repo

Let see what other reviewers think about that :)

Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnadyaNair I think all this detail isn't needed, but you could put it in the support repo. If you have all these details, it may not let the readers move down the organisation home page, and see popular repositories. A simple readme will have a bigger impact.

However, I really like the banner! This should be used somewhere in this org!

Thank you.

@AnadyaNair
Copy link
Author

Thank you for the reviews!

Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnadyaNair there seems to be conflicts that need resolving thank you.

@schmelto
Copy link
Contributor

I don't think we need to add that much content to the org page.

+ For QnA, we have our support repo

Let see what other reviewers think about that :)

Agree with that

Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the FAQ section (which I think should go in the support repo), the rest looks great to me! Please remove the FAQ, Thanks!

__
sema-logo  Summary: 🏆 This code is awesome

@eddiejaoude
Copy link
Member

Looks good, I think there is too much in bold/big writing - I always recommend adding a small section at a time, so we can continually keep merging things in (little and often is better for you and the project)

Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any updates on this pr? Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants