Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

added husky,lint staged and prettier. #70

Closed

Conversation

rahulkhattri0
Copy link

No description provided.

Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you close this PR? 😅 Also please do not open PRs without getting the issue assigned? 🙂

@rahulkhattri0
Copy link
Author

rahulkhattri0 commented Nov 18, 2021

closed it by mistake. I'm sorry for that. Also ,I have been assinged to the husky issue.

@gptkrsh
Copy link

gptkrsh commented Nov 18, 2021

closed it by mistake. I'm sorry for that. Also ,I have been assinged to the husky issue.

But you added linters? 😅

@rahulkhattri0
Copy link
Author

Lint staged collects all the staged files and husky runs the pre commit hook. Prettier formats the code

@gptkrsh
Copy link

gptkrsh commented Nov 18, 2021

Lint staged collects all the staged files and husky runs the pre-commit hook. Prettier formats the code

isn't eslint: #41 assigned to @StarTrooper08? 🤔

@rahulkhattri0
Copy link
Author

I have not used eslint

@gptkrsh
Copy link

gptkrsh commented Nov 18, 2021

I have not used eslint

your PR adds eslintConfig key to package.json

@rahulkhattri0
Copy link
Author

I'll remove it

@rahulkhattri0
Copy link
Author

#71 (comment)

@rahulkhattri0
Copy link
Author

#71 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants