Add explicit file list to temporary eslint errors converted to warnings #5704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/eslint-config
branch
from
21541a0 to
95640b9
Compare
swansontec
approved these changes
Aug 26, 2025
Comment on lines
+49
to
+62
| new RegExp( | ||
| `^(\\s*)(['"])${stagedFile.replace( | ||
| /[.*+?^${}()|[\]\\]/g, | ||
| '\\$&' | ||
| )}\\2,?\\s*$`, | ||
| 'gm' | ||
| ), | ||
| new RegExp( | ||
| `^(\\s*)(['"])${stagedFile.replace( | ||
| /[.*+?^${}()|[\]\\]/g, | ||
| '\\$&' | ||
| )}\\2,?\\s*\n`, | ||
| 'gm' | ||
| ) |
There was a problem hiding this comment.
Editing JS. Wow. Yeah. OK. We could probably do it more "dumb" than this, but I see that it probably works? So yay? We can leave it as-is, since it's temporary anyhow.
I know there was talk of putting the list into JSON, and then importing that into the ESLint config, but I guess that's not really needed now.
samholmes
force-pushed
the
sam/eslint-config
branch
from
558619f to
5a35054
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
When developers modify files that are in the ESLint warnings list, this pre-commit hook automatically removes those files from the warnings list in eslint.config.mjs. This enforces that any touched file must have its ESLint errors fixed before committing. The update-eslint-warnings script runs before lint-staged in the pre-commit hook, ensuring modified files are subject to full ESLint error checking rather than just warnings. This helps gradually clean up the codebase as developers work on different files.
samholmes
force-pushed
the
sam/eslint-config
branch
from
5a35054 to
5840de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: