Sam/infinite ramp plugin #5715
Sam/infinite ramp plugin #5715
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
4 times, most recently
from
2311b66 to
9ebe8d3
Compare
Jon-edge
force-pushed
the
sam/infinite-ramp-plugin
branch
2 times, most recently
from
4a14ce2 to
00f5b8c
Compare
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
3 times, most recently
from
6e2b3b7 to
5cf5c68
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
from
5cf5c68 to
53d9054
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| getAuthState: false, // This is always local, no API call | ||
| saveCustomerId: false, // This is always local, no API call | ||
| isAuthenticated: false // This is always local, no API call | ||
| } |
There was a problem hiding this comment.
I disagree with Cursor on this one. This is critical for development since we don't want to use real funds for testing.
| } | ||
|
|
||
| resolve({ confirmed: true, transfer }) | ||
| } |
There was a problem hiding this comment.
Cursor makes a valid point - the funds could come from many utxo's, not necessarily our latest receive address (indeed, this is usually a fresh address for utxo coins). If Infinite.dev is just using this as a refund address, then it's fine. If not, we might need a rethink.
src/util/vault/edgeVault.ts
Outdated
| try { | ||
| const record = await makeRecord(info) | ||
| const json = wasVaultPersonalRecord(record) | ||
| await vaultDisklet.setText(`${info.type}/${record.uuid}.json`, json) |
There was a problem hiding this comment.
So we are saving data in edgeVault/{randomHex}.json. Ok, I guess this is fine.
They don't really need to be UUID's - we could do 128 bits of base58 (about 21 characters). This would simplify creating these things, and since we don't really parse them or read into them, it wouldn't affect anybody.
There was a problem hiding this comment.
If you feel like its worth it to switch from UUID to hex or base58 encoding of random bits, then I'll do it.
There was a problem hiding this comment.
I feel like we should change the name uuid to recordId or vaultId or such, which says what the ID is used for, not what format it is.
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
from
85e99f7 to
63fa557
Compare
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
from
63fa557 to
3f584e8
Compare
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
from
3f584e8 to
28a711f
Compare
2 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
https://app.asana.com/0/0/1211067783183644(original task; first attempt)Note
Introduces the Infinite ramp plugin with full auth/KYC/TOS/bank workflows and new UI scenes, adds a vault for user/bank data, updates deep links/navigation, and enhances shared utilities & inputs.
infiniteramp plugin (src/plugins/ramps/infinite/*) with API client, normalized currency mapping, and workflows: authenticate, KYC (webview/polling), TOS, bank account add, confirmation, transfer status.allRampPlugins.ts; env config supportsRAMP_PLUGIN_INITS.infinite.RampKycFormScene,RampPendingScene,RampBankFormScene,RampBankRoutingDetailsScene,RampConfirmationScenewith navigation wiring inMain.tsxand DevTest hooks.ramplink type handling inDeepLinkTypes, parser, andDeepLinkingActions(including legacyfiatProviderpassthrough).util/vault/*) to create/update/getpersonalInfo,addressInfo,bankAccountInforecords; comprehensive tests added.FilledTextInput: addminLength, improved message styling (danger/warn), snapshot updates.SectionHeading, tweakParagraphprops typing.cleanFetch: switch toURL, addasSearchParamscodec;PeriodicTask:setDelay, numericwait.CurrencyInfoHelpers: addgetContractAddress.DEBUG_VERBOSE_LOGGING.@noble/curvesand@noble/hashesfor signing; lockfile updated.Written by Cursor Bugbot for commit 28a711f. This will update automatically on new commits. Configure here.