Sam/ramp constraints #5778
Open
Sam/ramp constraints #5778
+380
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require `wallet` and use `currencyInfo` to get the `pluginId`.
We're removing `iach` from ramp plugin implementation and deprecating the value for documentation purposes. We'll remove the value variant completely when it's no longer a dependency for legacy code.
samholmes
force-pushed
the
sam/ramp-constraints
branch
from
c937925 to
63411e6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
We need generators to not early exit on constraints so they're all applied. This is nice so we don't need to couple our constraints to other constrains when adding/removing. The contract is that all the constraints will get equal chance of being applied.
We need generators to not early exit on constraints so they're all applied. This is nice so we don't need to couple our constraints to other constrains when adding/removing. The contract is that all the constraints will get equal chance of being applied.
The list of supported countries is copied from the `buyPluginList.json` file. Revolut is not supported for sell direction, so no need to get the country codes from `sellPluginList.json`.
This was missing from the paybisProvider implementation.
The list of supported countries is copied from the `buyPluginList.json` and `sellPluginList.json`.
samholmes
force-pushed
the
sam/ramp-constraints
branch
from
63411e6 to
6f5eed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Adds a ramp constraints layer and refactors request/types; updates all ramp plugins and UI to enforce constraints, derive pluginId from wallet, and expand Simplex payment types.
rampConstraints.tsandutils/constraintUtils.tswith global/per-request validators (validateRampCheckSupportRequest,validateRampQuoteRequest).rampPluginTypes.ts:CryptoAsset.RampCheckSupportRequest.cryptoAssetnowCryptoAsset.RampQuoteRequestnow requireswalletand removespluginId.RampSelectOptionScene.tsx:wallet.currencyInfo.pluginIdforselectedCrypto.pluginId.approveQuotewithrampQuoteRequest.wallet(no non-null assertion).checkSupportand per-payment-type checks infetchQuotes; derivecurrencyPluginIdfromrequest.wallet.currencyInfo.pluginId.ach(maps, allowed types, reverse maps) and remove special-case credit filtering (handled by constraints).Written by Cursor Bugbot for commit 6f5eed7. This will update automatically on new commits. Configure here.