Optimize exchange rate asset pair cache handling #5829
+115
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the cache, and periodic looping, this isn't really necessary and can actually slow down rate updates
Assets that cannot have not found a rate, like obscure or invalid tokens, shouldn't slow down the initial lookup on login. Also, we were previously storing pairs in the cache along with dates which meant historical rates were being queried as well. Fix eslint error in exchangeRates.ts
peachbits
force-pushed
the
matthew/pair-cache
branch
from
50aed5c to
e869a1a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| cryptoPairs: Array.from(cryptoPairMap.values()), | ||
| fiatPairs: Array.from(fiatPairMap.values()) | ||
| cryptoPairs: Array.from(cryptoPairCache.values()), | ||
| fiatPairs: Array.from(fiatPairCache.values()) |
There was a problem hiding this comment.
Bug: Cache clears failed rate pairs, causing missing data
The exchange rate cache now only persists asset pairs that successfully returned rate data, rather than all initially requested pairs. If a rate fetch fails, the asset pair is removed from the cache and won't be tracked or re-requested until its associated wallet is active again, potentially causing missing exchange rates.
swansontec
approved these changes
Nov 4, 2025
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
It seems like this would be better, but as Cursor points out, we do run the risk of losing rates that we fail to fetch. It might make sense to pre-populate these two sets with the existing data, which would turn this into an update rather than a stomp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Parallelizes v3/rates requests and rebuilds asset pair caches from returned results; exports createRateKey and minor util cleanups.
v3/ratesPOST requests withPromise.allSettledand aggregate results intorates.cryptoPairs/fiatPairs) from actual responses usingcreateRateKey, replacing prior map-based cache population.createRateKeyfromsrc/util/exchangeRates.tsand add minor type/condition tweaks.Written by Cursor Bugbot for commit e869a1a. This will update automatically on new commits. Configure here.