-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Integrate EduTheia landing page with separate tag parameter #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
eab99f7
feat: Integrate EduTheia landing page with separate tag parameter
CodeByNikolas f98c9e2
no custom
CodeByNikolas 73c40d8
check footer for new landing apge
CodeByNikolas e159b25
chore: Bump theia-cloud chart to 1.3.0-next.4 (#63)
CodeByNikolas e5c87d2
revert: Restore proper test3 footer links (remove test URLs)
CodeByNikolas 9083a5f
Apply suggestion from @Copilot
CodeByNikolas 3dde7e6
chore: Trigger rebase after main branch updates
CodeByNikolas bfe2a7d
chore: Merge main into edutheia branch - resolve Chart.lock timestamp…
CodeByNikolas 16cc1cb
rollen test
CodeByNikolas 99e350e
undo rollen
CodeByNikolas e88558e
all envs
CodeByNikolas a47e4ac
restore LS
CodeByNikolas 08d8c4c
chore: merge main into feat/edutheia-landing-page-integration and upd…
CodeByNikolas 865a6c7
fix: correct image registry paths for operator, service and landing page
CodeByNikolas 7ae3a08
fix: lowercase GHCR landing-page image references
CodeByNikolas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,15 +52,13 @@ theia-cloud: | |
|
|
||
| preloading: | ||
| images: | ||
| - ghcr.io/ls1intum/theia/landing-page:latest | ||
| - ghcr.io/ls1intum/edutheia-landing-page:latest | ||
CodeByNikolas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - ghcr.io/ls1intum/theia/java-17:latest | ||
| - ghcr.io/ls1intum/theia/c:latest | ||
| - ghcr.io/ls1intum/theia/javascript:latest | ||
| - ghcr.io/ls1intum/theia/ocaml:latest | ||
| - ghcr.io/ls1intum/theia/rust:latest | ||
| - ghcr.io/ls1intum/theia/python:latest | ||
CodeByNikolas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - ghcr.io/ls1intum/theia/theia-no-ls:pr-46 | ||
| - ghcr.io/ls1intum/theia/langserver-java:pr-46 | ||
|
|
||
| imagePullPolicy: Always | ||
|
|
||
|
|
@@ -70,7 +68,7 @@ theia-cloud: | |
|
|
||
| landingPage: | ||
| # We use the try now page as landing page since the default does not support mutliple apps -> https://github.com/eclipsesource/theia-cloud/discussions/301 | ||
CodeByNikolas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| image: ghcr.io/ls1intum/theia/landing-page | ||
| image: ghcr.io/ls1intum/edutheia-landing-page | ||
| # We can define a default blueprint | ||
|
|
||
| # 1. The actual image data (Must be a Base64 encoded string) | ||
|
|
@@ -95,25 +93,23 @@ theia-cloud: | |
| label: Python | ||
| rust-latest: | ||
| label: Rust | ||
| java-ls-test: | ||
| label: Java LS Test | ||
| infoTitle: "🚀 Welcome to Test3 IDE Environment" | ||
| infoText: "This is a testing environment for Theia Cloud. Select your programming language and start coding in seconds!" | ||
| loadingText: "⚡ Setting up your development workspace..." | ||
| infoTitle: "🚀 Welcome to Test3 IDE Environment - Where we move fast and break things - mostly breaks things.. 🤠🤠" | ||
| infoText: "This is a testing environment for Theia Cloud. Should be fun to use, but don't expect too much." | ||
| loadingText: "Ich lade grade, geb mir mal ne Sekunde" | ||
| footerLinks: | ||
| attribution: | ||
| text: "Built by TUM LS1 Team 👨💻" | ||
| url: "https://aet.cit.tum.de/" | ||
| text: "Rollen" | ||
| url: "https://www.youtube.com/watch?v=dQw4w9WgXcQ" | ||
| version: "Test3-v1.0.0" | ||
| bugReport: | ||
| text: "Report a bug 🐛" | ||
| url: "https://github.com/ls1intum/theia-cloud/issues" | ||
| text: "Rollen" | ||
| url: "https://www.youtube.com/watch?v=dQw4w9WgXcQ" | ||
| featureRequest: | ||
| text: "Request a feature ✨" | ||
| url: "https://github.com/ls1intum/theia-cloud/issues" | ||
| text: "Rollen" | ||
| url: "https://www.youtube.com/watch?v=dQw4w9WgXcQ" | ||
| about: | ||
| text: "About" | ||
| url: "https://aet.cit.tum.de/" | ||
| text: "Rollen" | ||
| url: "https://www.youtube.com/watch?v=dQw4w9WgXcQ" | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| keycloak: | ||
| enable: true | ||
|
|
@@ -127,13 +123,6 @@ theia-cloud: | |
| # -- The client-id. Only has to be specified when enable: true | ||
| clientId: "theia-test" | ||
|
|
||
| theia-appdefinitions: | ||
| apps: | ||
| - name: java-ls-test | ||
| image: ghcr.io/ls1intum/theia/theia-no-ls | ||
| imageTag: pr-46 | ||
| options: | ||
| langserver-image: ghcr.io/ls1intum/theia/langserver-java:pr-46 | ||
|
|
||
| monitoring: | ||
| targetNamespaces: | ||
|
Comment on lines
139
to
149
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes the reusable deploy workflow always deploy
ghcr.io/ls1intum/edutheia-landing-page(and preloads it) for any environment that calls this workflow (including staging + prod). The PR description implies rollout/testing is focused on test3; if you want a staged rollout, consider making the landing page image/repo configurable per environment (values.yaml) and only overriding it for test3 until validated.