-
Notifications
You must be signed in to change notification settings - Fork 0
fix(test3): point landing page image to eduidec repository #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eab99f7
f98c9e2
73c40d8
e159b25
e5c87d2
9083a5f
3dde7e6
bfe2a7d
16cc1cb
99e350e
e88558e
a47e4ac
08d8c4c
865a6c7
7ae3a08
6a53fe8
d364437
21f5254
985715d
b747324
2b98737
79858a9
5096fd5
8d6b04e
792f4bd
ca037ce
104825f
7bdbd38
42d1011
84c0d06
ab9102b
47b5766
1a913fb
75e76db
3c24f99
636c3d7
e3d645c
728b359
7a7a92a
c2fc148
3fb95ce
6ef8ba6
d108d4d
d3ebc08
4d5838d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -43,7 +43,7 @@ theia-cloud: | |||||||
| interval: 3 | ||||||||
|
|
||||||||
| operator: | ||||||||
| image: ghcr.io/eduide/eduide-cloud/operator:pr-70 | ||||||||
| image: ghcr.io/eduide/eduide-cloud/operator:pr-100 | ||||||||
| #eagerStart: false | ||||||||
| replicas: 1 | ||||||||
| sessionsPerUser: 10 | ||||||||
|
|
@@ -56,24 +56,19 @@ theia-cloud: | |||||||
| ephemeral-storage: "256Mi" | ||||||||
|
|
||||||||
| service: | ||||||||
| image: ghcr.io/eduide/eduide-cloud/service:pr-70 | ||||||||
| image: ghcr.io/eduide/eduide-cloud/service:pr-100 | ||||||||
| adminApiTokenSecret: | ||||||||
|
Comment on lines
45
to
60
|
||||||||
| name: service-admin-api-token | ||||||||
| key: ADMIN_API_TOKEN | ||||||||
|
|
||||||||
| preloading: | ||||||||
| images: | ||||||||
|
||||||||
| images: | |
| images: | |
| - ghcr.io/eduide/eduidec-landing-page:pr-100 |
Copilot
AI
Mar 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says “does not support mutliple apps” — “mutliple” is misspelled. Please correct it to “multiple”.
| # We use the try now page as landing page since the default does not support mutliple apps -> https://github.com/eclipsesource/theia-cloud/discussions/301 | |
| # We use the try now page as landing page since the default does not support multiple apps -> https://github.com/eclipsesource/theia-cloud/discussions/301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clean-install purge step will never run in this reusable workflow: when
deploy-theia.ymlis invoked viaworkflow_call,github.event_nameisworkflow_call, notworkflow_dispatch, so thisif:condition is always false. Rely oninputs.clean_installalone (the caller already gates it to manual dispatch) or pass an explicit “triggered_by_dispatch” input if you need extra protection.